Patchwork UBI: add in hex the value for UBI_INTERNAL_VOL_START to comment

login
register
mail settings
Submitter Joel Reardon
Date May 20, 2012, 11:42 a.m.
Message ID <alpine.DEB.2.00.1205201340410.26953@eristoteles.iwoars.net>
Download mbox | patch
Permalink /patch/160255/
State New
Headers show

Comments

Joel Reardon - May 20, 2012, 11:42 a.m.
Explicitly provide the first internal volume ID value in the comment for
UBI_INTERNAL_VOL_START. This allows developers who, when adding features
related to volume ids and observe unexpected very large volume ids, to grep
for the observed value in the source code and find out immediately that it is
expected behaviour.

Signed-off-by: Joel Reardon <reardonj@inf.ethz.ch>
---
 drivers/mtd/ubi/ubi-media.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Artem Bityutskiy - May 20, 2012, 6:32 p.m.
On Sun, 2012-05-20 at 13:42 +0200, Joel Reardon wrote:
> Explicitly provide the first internal volume ID value in the comment for
> UBI_INTERNAL_VOL_START. This allows developers who, when adding features
> related to volume ids and observe unexpected very large volume ids, to grep
> for the observed value in the source code and find out immediately that it is
> expected behaviour.
> 
> Signed-off-by: Joel Reardon <reardonj@inf.ethz.ch>

Pushed to linux-ubi.git, it is also in your branch, thanks!

Patch

diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi/ubi-media.h
index 6fb8ec2..9dab25d 100644
--- a/drivers/mtd/ubi/ubi-media.h
+++ b/drivers/mtd/ubi/ubi-media.h
@@ -298,8 +298,8 @@  struct ubi_vid_hdr {
 #define UBI_INT_VOL_COUNT 1

 /*
- * Starting ID of internal volumes. There is reserved room for 4096 internal
- * volumes.
+ * Starting ID of internal volumes: 0x7fffefff.
+ * There is reserved room for 4096 internal volumes.
  */
 #define UBI_INTERNAL_VOL_START (0x7FFFFFFF - 4096)