From patchwork Fri May 18 14:18:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 160118 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8BB3CB6EF3 for ; Sat, 19 May 2012 00:19:29 +1000 (EST) Received: from localhost ([::1]:56667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVO1f-0004CI-2s for incoming@patchwork.ozlabs.org; Fri, 18 May 2012 10:19:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVO1C-0003jy-L3 for qemu-devel@nongnu.org; Fri, 18 May 2012 10:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVO19-0005xE-6b for qemu-devel@nongnu.org; Fri, 18 May 2012 10:18:58 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:34862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVO18-0005va-U9 for qemu-devel@nongnu.org; Fri, 18 May 2012 10:18:55 -0400 Received: by mail-pz0-f45.google.com with SMTP id v2so4854728dad.4 for ; Fri, 18 May 2012 07:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=cN9qmxMwiNeAQD0y2mk94rOHnHflbjlwN4NXRcFnFnw=; b=AaNFBV9oI0xkSlxXKT7HSzYtDOITyiHV6SGW7/uU+M7gAKSU9+4QhL+YaqxJ4UFYDk pfVDnBQ3VVpiF5lmmIRG9onqXlnVZlblS7CweNEDjOtW4gnEx5jHg7F/h2xiqpulGe/I 0WyPny9433omQkXVyvOamDv+9N2R+U74I7+H7Yxyq5XRXUOLQz7CHuHpx3tUSiTCjueb 4LuYgQi2M1d29276t5086tq9EYKBl9Ta5jy6ISSIwqOGKBMFCFdkWiUqL2IOOnK4jv9J NwZdfiD3h8EQsDV0imR27a20DKnlWokiUHfNJSFPYDWSfc4rakrzpw52r0BCgK9zLF7X czYg== Received: by 10.68.131.38 with SMTP id oj6mr39342465pbb.39.1337350734080; Fri, 18 May 2012 07:18:54 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-182-16.ip50.fastwebnet.it. [93.34.182.16]) by mx.google.com with ESMTPS id gq5sm11145798pbc.65.2012.05.18.07.18.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 May 2012 07:18:53 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 18 May 2012 16:18:28 +0200 Message-Id: <1337350712-29183-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.10.1 In-Reply-To: <1337350712-29183-1-git-send-email-pbonzini@redhat.com> References: <1337350712-29183-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.45 Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, anthony@codemonkey.ws Subject: [Qemu-devel] [RFC PATCH 3/7] block: do not pass BDRV_O_CACHE_WB to the protocol X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Formats are entirely in charge of flushes for metadata writes. For guest-initiated writes, a writethrough cache is faked in the block layer. Signed-off-by: Paolo Bonzini --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 3db7150..b3d0054 100644 --- a/block.c +++ b/block.c @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, if (drv->bdrv_file_open) { ret = drv->bdrv_file_open(bs, filename, open_flags); } else { - ret = bdrv_file_open(&bs->file, filename, open_flags); + ret = bdrv_file_open(&bs->file, filename, open_flags & ~BDRV_O_CACHE_WB); if (ret >= 0) { ret = drv->bdrv_open(bs, open_flags); }