| Message ID | 1337345912-29649-2-git-send-email-i.mitsyanko@samsung.com |
|---|---|
| State | New |
| Headers | show |
Am 18.05.2012 14:58, schrieb Igor Mitsyanko: > It has been noted that "All rights reserved" statement conflicts with GPL, > remove it. > > Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com> > --- [...] > diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c > index 80af22c..a4a159a 100644 > --- a/hw/exynos4210_combiner.c > +++ b/hw/exynos4210_combiner.c > @@ -1,8 +1,7 @@ > /* > * Samsung exynos4210 Interrupt Combiner > * > - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. > - * All rights reserved. > + * Copyright (c) 2011 Samsung Electronics Co., Ltd. > * > * Evgeny Voevodin <e.voevodin@samsung.com> > * [snip] In multiple files you change the copyright from 2000-2011 to just 2011. Intentional? Andreas
On 05/18/2012 05:26 PM, Andreas Färber wrote: > Am 18.05.2012 14:58, schrieb Igor Mitsyanko: >> It has been noted that "All rights reserved" statement conflicts with GPL, >> remove it. >> >> Signed-off-by: Igor Mitsyanko<i.mitsyanko@samsung.com> >> --- > [...] >> diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c >> index 80af22c..a4a159a 100644 >> --- a/hw/exynos4210_combiner.c >> +++ b/hw/exynos4210_combiner.c >> @@ -1,8 +1,7 @@ >> /* >> * Samsung exynos4210 Interrupt Combiner >> * >> - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. >> - * All rights reserved. >> + * Copyright (c) 2011 Samsung Electronics Co., Ltd. >> * >> * Evgeny Voevodin<e.voevodin@samsung.com> >> * > [snip] > > In multiple files you change the copyright from 2000-2011 to just 2011. > Intentional? > > Andreas > Yes, all these files were created in 2011 so this time period makes no sense. I hope you wouldn't tell me that its an unrelated changes and should be in a separate patch :)
Suggest to change it to 2011-2012, according to real development frame. Thanks, Dmitry Solodkiy, Emulator/Kernel PL, Mobile Group, Moscow R&D center, Samsung Electronics // please use tnef utility to extract Outlook attachments on Linux -----Original Message----- From: Andreas Färber [mailto:afaerber@suse.de] Sent: Friday, May 18, 2012 5:27 PM To: Igor Mitsyanko Cc: qemu-devel@nongnu.org; peter.maydell@linaro.org; aliguori@us.ibm.com; kyungmin.park@samsung.com; d.solodkiy@samsung.com Subject: Re: [Qemu-devel] [PATCH RESEND 1.1] exynos4210: drop "All rights reserved" line from files license Am 18.05.2012 14:58, schrieb Igor Mitsyanko: > It has been noted that "All rights reserved" statement conflicts with > GPL, remove it. > > Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com> > --- [...] > diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c index > 80af22c..a4a159a 100644 > --- a/hw/exynos4210_combiner.c > +++ b/hw/exynos4210_combiner.c > @@ -1,8 +1,7 @@ > /* > * Samsung exynos4210 Interrupt Combiner > * > - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. > - * All rights reserved. > + * Copyright (c) 2011 Samsung Electronics Co., Ltd. > * > * Evgeny Voevodin <e.voevodin@samsung.com> > * [snip] In multiple files you change the copyright from 2000-2011 to just 2011. Intentional? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Am 18.05.2012 15:36, schrieb Igor Mitsyanko: > On 05/18/2012 05:26 PM, Andreas Färber wrote: >> Am 18.05.2012 14:58, schrieb Igor Mitsyanko: >>> It has been noted that "All rights reserved" statement conflicts with >>> GPL, >>> remove it. >>> >>> Signed-off-by: Igor Mitsyanko<i.mitsyanko@samsung.com> >>> --- >> [...] >>> diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c >>> index 80af22c..a4a159a 100644 >>> --- a/hw/exynos4210_combiner.c >>> +++ b/hw/exynos4210_combiner.c >>> @@ -1,8 +1,7 @@ >>> /* >>> * Samsung exynos4210 Interrupt Combiner >>> * >>> - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. >>> - * All rights reserved. >>> + * Copyright (c) 2011 Samsung Electronics Co., Ltd. >>> * >>> * Evgeny Voevodin<e.voevodin@samsung.com> >>> * >> [snip] >> >> In multiple files you change the copyright from 2000-2011 to just 2011. >> Intentional? >> > Yes, all these files were created in 2011 so this time period makes no > sense. I hope you wouldn't tell me that its an unrelated changes and > should be in a separate patch :) No, no, that's a Samsung decision. But if you had explained it in the commit message it would've avoided my question. :) No need to respin. I guess it's more a question of through who's queue this goes. Andreas
diff --git a/hw/exynos4210.c b/hw/exynos4210.c index afc4bdc..a3a06f7 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -1,7 +1,7 @@ /* * Samsung exynos4210 SoC emulation * - * Copyright (c) 2011 Samsung Electronics Co., Ltd. All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * Maksim Kozlov <m.kozlov@samsung.com> * Evgeny Voevodin <e.voevodin@samsung.com> * Igor Mitsyanko <i.mitsyanko@samsung.com> diff --git a/hw/exynos4210.h b/hw/exynos4210.h index f7c7027..79c1b78 100644 --- a/hw/exynos4210.h +++ b/hw/exynos4210.h @@ -1,7 +1,7 @@ /* * Samsung exynos4210 SoC emulation * - * Copyright (c) 2011 Samsung Electronics Co., Ltd. All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * Maksim Kozlov <m.kozlov@samsung.com> * Evgeny Voevodin <e.voevodin@samsung.com> * Igor Mitsyanko <i.mitsyanko@samsung.com> diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c index 80af22c..a4a159a 100644 --- a/hw/exynos4210_combiner.c +++ b/hw/exynos4210_combiner.c @@ -1,8 +1,7 @@ /* * Samsung exynos4210 Interrupt Combiner * - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. - * All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * * Evgeny Voevodin <e.voevodin@samsung.com> * diff --git a/hw/exynos4210_fimd.c b/hw/exynos4210_fimd.c index 3313f00..0cedf6b 100644 --- a/hw/exynos4210_fimd.c +++ b/hw/exynos4210_fimd.c @@ -1,8 +1,7 @@ /* * Samsung exynos4210 Display Controller (FIMD) * - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. - * All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * Based on LCD controller for Samsung S5PC1xx-based board emulation * by Kirill Batuzov <batuzovk@ispras.ru> * diff --git a/hw/exynos4210_gic.c b/hw/exynos4210_gic.c index e1b215e..3bd4f3e 100644 --- a/hw/exynos4210_gic.c +++ b/hw/exynos4210_gic.c @@ -1,8 +1,7 @@ /* * Samsung exynos4210 GIC implementation. Based on hw/arm_gic.c * - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. - * All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * * Evgeny Voevodin <e.voevodin@samsung.com> * diff --git a/hw/exynos4210_mct.c b/hw/exynos4210_mct.c index 7474fcf..8838126 100644 --- a/hw/exynos4210_mct.c +++ b/hw/exynos4210_mct.c @@ -1,8 +1,7 @@ /* * Samsung exynos4210 Multi Core timer * - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. - * All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * * Evgeny Voevodin <e.voevodin@samsung.com> * diff --git a/hw/exynos4210_pwm.c b/hw/exynos4210_pwm.c index 6243e59..98227e5 100644 --- a/hw/exynos4210_pwm.c +++ b/hw/exynos4210_pwm.c @@ -1,8 +1,7 @@ /* * Samsung exynos4210 Pulse Width Modulation Timer * - * Copyright (c) 2000 - 2011 Samsung Electronics Co., Ltd. - * All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co., Ltd. * * Evgeny Voevodin <e.voevodin@samsung.com> * diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c index ea32c51..b794fa8 100644 --- a/hw/exynos4_boards.c +++ b/hw/exynos4_boards.c @@ -1,7 +1,7 @@ /* * Samsung exynos4 SoC based boards emulation * - * Copyright (c) 2011 Samsung Electronics Co., Ltd. All rights reserved. + * Copyright (c) 2011 Samsung Electronics Co. * Maksim Kozlov <m.kozlov@samsung.com> * Evgeny Voevodin <e.voevodin@samsung.com> * Igor Mitsyanko <i.mitsyanko@samsung.com>
It has been noted that "All rights reserved" statement conflicts with GPL, remove it. Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com> --- hw/exynos4210.c | 2 +- hw/exynos4210.h | 2 +- hw/exynos4210_combiner.c | 3 +-- hw/exynos4210_fimd.c | 3 +-- hw/exynos4210_gic.c | 3 +-- hw/exynos4210_mct.c | 3 +-- hw/exynos4210_pwm.c | 3 +-- hw/exynos4_boards.c | 2 +- 8 files changed, 8 insertions(+), 13 deletions(-)