From patchwork Fri May 18 11:32:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] UBIFS: make ubifs_lpt_init clean-up in case of failure Date: Fri, 18 May 2012 01:32:36 -0000 From: Artem Bityutskiy X-Patchwork-Id: 160097 Message-Id: <1337340757-26127-1-git-send-email-dedekind1@gmail.com> To: Sidney Amani Cc: Ben Gardiner , MTD Maling List From: Artem Bityutskiy Most functions in UBIFS follow the following designn pattern: if the function allocates multiple resources, and failss at some point, it frees what it has allocated and returns an error. So the caller can rely on the fact that the callee has cleaned up everything after own failure. Signed-off-by: Artem Bityutskiy Acked-by: Sidney Amani --- fs/ubifs/lpt.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c index 2054e81..b4280c4 100644 --- a/fs/ubifs/lpt.c +++ b/fs/ubifs/lpt.c @@ -1740,16 +1740,20 @@ int ubifs_lpt_init(struct ubifs_info *c, int rd, int wr) if (rd) { err = lpt_init_rd(c); if (err) - return err; + goto out_err; } if (wr) { err = lpt_init_wr(c); if (err) - return err; + goto out_err; } return 0; + +out_err: + ubifs_lpt_free(c, 0); + return err; } /**