Patchwork mtd: Fix typo in Kconfig

login
register
mail settings
Submitter Frank Svendsbøe
Date May 17, 2012, 8:43 p.m.
Message ID <1337287389-28386-1-git-send-email-frank.svendsboe@gmail.com>
Download mbox | patch
Permalink /patch/160015/
State New
Headers show

Comments

Frank Svendsbøe - May 17, 2012, 8:43 p.m.
MTD_OF_PARTS and the default setting is not working due to using 'Y'
instead of 'y', introduced in commit
d6137badeff1ef64b4e0092ec249ebdeaeb3ff37. This made our board, and
possibly other boards using DTS defined partitions and not having
CONFIG_MTD_OF_PARTS=y defined in the defconfig, fail to mount root
after v3.1.

Signed-off-by: Frank Svendsboe <frank.svendsboe@gmail.com>
---
 drivers/mtd/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Artem Bityutskiy - May 18, 2012, 11 a.m.
On Thu, 2012-05-17 at 22:43 +0200, Frank Svendsboe wrote:
> MTD_OF_PARTS and the default setting is not working due to using 'Y'
> instead of 'y', introduced in commit
> d6137badeff1ef64b4e0092ec249ebdeaeb3ff37. This made our board, and
> possibly other boards using DTS defined partitions and not having
> CONFIG_MTD_OF_PARTS=y defined in the defconfig, fail to mount root
> after v3.1.

The commit was released in v3.2, so it not v3.1 probably?

> Signed-off-by: Frank Svendsboe <frank.svendsboe@gmail.com>

I've amended the subject to make it look scarier than just a fix of a
typo, added a tag for the stable tree, and pushed to l2-mtd.git, thanks!

commit aa2465b2d5d44defb269ac66a2d2b6e6b8feb399
Author: Frank Svendsboe <frank.svendsboe@gmail.com>
Date:   Thu May 17 22:43:09 2012 +0200

    mtd: of_parts: fix breakage in Kconfig
    
    MTD_OF_PARTS and the default setting is not working due to using 'Y'
    instead of 'y', introduced in commit
    d6137badeff1ef64b4e0092ec249ebdeaeb3ff37. This made our board, and
    possibly other boards using DTS defined partitions and not having
    CONFIG_MTD_OF_PARTS=y defined in the defconfig, fail to mount root.
    
    Signed-off-by: Frank Svendsboe <frank.svendsboe@gmail.com>
    Cc: stable@kernel.org [3.2+]
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Frank Svendsbøe - May 18, 2012, 1:57 p.m.
On Fri, May 18, 2012 at 02:00:34PM +0300, Artem Bityutskiy wrote:
> On Thu, 2012-05-17 at 22:43 +0200, Frank Svendsboe wrote:
> > MTD_OF_PARTS and the default setting is not working due to using 'Y'
> > instead of 'y', introduced in commit
> > d6137badeff1ef64b4e0092ec249ebdeaeb3ff37. This made our board, and
> > possibly other boards using DTS defined partitions and not having
> > CONFIG_MTD_OF_PARTS=y defined in the defconfig, fail to mount root
> > after v3.1.
> 
> The commit was released in v3.2, so it not v3.1 probably?
>

It was committed between 3.1 and 3.2-rc1. I said _after_ 3.1, so it is
not completely wrong either. Feel free to change to commit message, or
I can resend the patch if you want me to.

> > Signed-off-by: Frank Svendsboe <frank.svendsboe@gmail.com>
> 
> I've amended the subject to make it look scarier than just a fix of a
> typo, added a tag for the stable tree, and pushed to l2-mtd.git, thanks!
> 
> commit aa2465b2d5d44defb269ac66a2d2b6e6b8feb399
> Author: Frank Svendsboe <frank.svendsboe@gmail.com>
> Date:   Thu May 17 22:43:09 2012 +0200
> 
>     mtd: of_parts: fix breakage in Kconfig
>     
>     MTD_OF_PARTS and the default setting is not working due to using 'Y'
>     instead of 'y', introduced in commit
>     d6137badeff1ef64b4e0092ec249ebdeaeb3ff37. This made our board, and
>     possibly other boards using DTS defined partitions and not having
>     CONFIG_MTD_OF_PARTS=y defined in the defconfig, fail to mount root.
>     
>     Signed-off-by: Frank Svendsboe <frank.svendsboe@gmail.com>
>     Cc: stable@kernel.org [3.2+]
>     Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 

Great. Thanks!

Patch

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 5760c1a..27143e0 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -128,7 +128,7 @@  config MTD_AFS_PARTS
 
 config MTD_OF_PARTS
 	tristate "OpenFirmware partitioning information support"
-	default Y
+	default y
 	depends on OF
 	help
 	  This provides a partition parsing function which derives