Patchwork [U-Boot,V3,1/2] tegra: whistler: reduce and comment network cfg options

login
register
mail settings
Submitter Stephen Warren
Date May 16, 2012, 4:36 p.m.
Message ID <1337186172-4832-1-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/159711/
State Accepted
Commit dae2aeab7161aad105cfdb61b722c9b22c6ac6fb
Headers show

Comments

Stephen Warren - May 16, 2012, 4:36 p.m.
From: Stephen Warren <swarren@nvidia.com>

CONFIG_CMD_PING/NFS aren't required for Whistler to boot.

Add some comments.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
v3: Fix duplicate #defines
v2: Fix typo in comment

Tom, this series replaces patches 3 and 4 of the V2 series I just posted.
---
 include/configs/whistler.h |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
Simon Glass - May 31, 2012, 11:31 p.m.
On Wed, May 16, 2012 at 9:36 AM, Stephen Warren <swarren@wwwdotorg.org>wrote:

> From: Stephen Warren <swarren@nvidia.com>
>

Acked-by: Simon Glass <sjg@chromium.org>


>
> CONFIG_CMD_PING/NFS aren't required for Whistler to boot.
>
> Add some comments.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v3: Fix duplicate #defines
> v2: Fix typo in comment
>
> Tom, this series replaces patches 3 and 4 of the V2 series I just posted.
> ---
>  include/configs/whistler.h |   10 ++++------
>  1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/include/configs/whistler.h b/include/configs/whistler.h
> index 2f2a512..6c0c77e 100644
> --- a/include/configs/whistler.h
> +++ b/include/configs/whistler.h
> @@ -74,16 +74,14 @@
>  #define CONFIG_USB_EHCI_TEGRA
>  #define CONFIG_USB_STORAGE
>  #define CONFIG_CMD_USB
> -#define CONFIG_USB_HOST_ETHER
> -#define CONFIG_USB_ETHER_SMSC95XX
> -#define CONFIG_USB_ETHER_ASIX
> +
> +/* USB networking support */
>  #define CONFIG_USB_HOST_ETHER
>  #define CONFIG_USB_ETHER_SMSC95XX
>  #define CONFIG_USB_ETHER_ASIX
>
> -#define CONFIG_CMD_NET      /* bootp, tftpboot, rarpboot    */
> -#define CONFIG_CMD_NFS      /* NFS support          */
> -#define CONFIG_CMD_PING
> +/* General networking support */
> +#define CONFIG_CMD_NET
>  #define CONFIG_CMD_DHCP
>
>  #include "tegra2-common-post.h"
> --
> 1.7.0.4
>
>

Patch

diff --git a/include/configs/whistler.h b/include/configs/whistler.h
index 2f2a512..6c0c77e 100644
--- a/include/configs/whistler.h
+++ b/include/configs/whistler.h
@@ -74,16 +74,14 @@ 
 #define CONFIG_USB_EHCI_TEGRA
 #define CONFIG_USB_STORAGE
 #define CONFIG_CMD_USB
-#define CONFIG_USB_HOST_ETHER
-#define CONFIG_USB_ETHER_SMSC95XX
-#define CONFIG_USB_ETHER_ASIX
+
+/* USB networking support */
 #define CONFIG_USB_HOST_ETHER
 #define CONFIG_USB_ETHER_SMSC95XX
 #define CONFIG_USB_ETHER_ASIX
 
-#define CONFIG_CMD_NET      /* bootp, tftpboot, rarpboot    */
-#define CONFIG_CMD_NFS      /* NFS support          */
-#define CONFIG_CMD_PING
+/* General networking support */
+#define CONFIG_CMD_NET
 #define CONFIG_CMD_DHCP
 
 #include "tegra2-common-post.h"