Patchwork [09/27] acpitables-0007: fix tests to work with new fwts logging

login
register
mail settings
Submitter Colin King
Date May 16, 2012, 1:20 p.m.
Message ID <1337174459-21597-10-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/159649/
State Accepted
Headers show

Comments

Colin King - May 16, 2012, 1:20 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 acpitables-0007/acpitables-0001.log |    6 +++---
 acpitables-0007/test-0001.sh        |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Keng-Yu Lin - May 23, 2012, 6:53 a.m.
On Wed, May 16, 2012 at 9:20 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  acpitables-0007/acpitables-0001.log |    6 +++---
>  acpitables-0007/test-0001.sh        |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/acpitables-0007/acpitables-0001.log b/acpitables-0007/acpitables-0001.log
> index 9001c4c..539e50e 100644
> --- a/acpitables-0007/acpitables-0001.log
> +++ b/acpitables-0007/acpitables-0001.log
> @@ -1,5 +1,5 @@
>  acpitables      ACPI table settings sanity checks.
> -acpitables      ---------------------------------------------------------
> +acpitables      ----------------------------------------------------------
>  acpitables      Test 1 of 1: Check ACPI tables.
>  acpitables      Table APIC not present to check.
>  acpitables      Table ECDT not present to check.
> @@ -122,7 +122,7 @@ acpitables      this will cause the kernel to oops, at best the kernel may
>  acpitables      ignore this. However, it should be fixed where possible.
>  acpitables
>  acpitables
> -acpitables      =========================================================
> +acpitables      ==========================================================
>  acpitables      2 passed, 14 failed, 0 warnings, 0 aborted, 0 skipped, 0
>  acpitables      info only.
> -acpitables      =========================================================
> +acpitables      ==========================================================
> diff --git a/acpitables-0007/test-0001.sh b/acpitables-0007/test-0001.sh
> index 5bdc106..770a8d3 100755
> --- a/acpitables-0007/test-0001.sh
> +++ b/acpitables-0007/test-0001.sh
> @@ -4,7 +4,7 @@ TEST="Test apcitables against broken ACPI XSDT table"
>  NAME=test-0001.sh
>  TMPLOG=$TMP/acpitables.log.$$
>
> -$FWTS -w 80 --dumpfile=acpidump-0001.log acpitables - | grep "^[0-9]*[ ]*acpitables" | cut -c7- > $TMPLOG
> +$FWTS --log-format="%line %owner " -w 80 --dumpfile=acpidump-0001.log acpitables - | grep "^[0-9]*[ ]*acpitables" | cut -c7- > $TMPLOG
>  diff $TMPLOG acpitables-0001.log >> $FAILURE_LOG
>  ret=$?
>  if [ $ret -eq 0 ]; then
> --
> 1.7.10
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - May 24, 2012, 6:35 a.m.
On 05/16/2012 09:20 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   acpitables-0007/acpitables-0001.log |    6 +++---
>   acpitables-0007/test-0001.sh        |    2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/acpitables-0007/acpitables-0001.log b/acpitables-0007/acpitables-0001.log
> index 9001c4c..539e50e 100644
> --- a/acpitables-0007/acpitables-0001.log
> +++ b/acpitables-0007/acpitables-0001.log
> @@ -1,5 +1,5 @@
>   acpitables      ACPI table settings sanity checks.
> -acpitables      ---------------------------------------------------------
> +acpitables      ----------------------------------------------------------
>   acpitables      Test 1 of 1: Check ACPI tables.
>   acpitables      Table APIC not present to check.
>   acpitables      Table ECDT not present to check.
> @@ -122,7 +122,7 @@ acpitables      this will cause the kernel to oops, at best the kernel may
>   acpitables      ignore this. However, it should be fixed where possible.
>   acpitables
>   acpitables
> -acpitables      =========================================================
> +acpitables      ==========================================================
>   acpitables      2 passed, 14 failed, 0 warnings, 0 aborted, 0 skipped, 0
>   acpitables      info only.
> -acpitables      =========================================================
> +acpitables      ==========================================================
> diff --git a/acpitables-0007/test-0001.sh b/acpitables-0007/test-0001.sh
> index 5bdc106..770a8d3 100755
> --- a/acpitables-0007/test-0001.sh
> +++ b/acpitables-0007/test-0001.sh
> @@ -4,7 +4,7 @@ TEST="Test apcitables against broken ACPI XSDT table"
>   NAME=test-0001.sh
>   TMPLOG=$TMP/acpitables.log.$$
>
> -$FWTS -w 80 --dumpfile=acpidump-0001.log acpitables - | grep "^[0-9]*[ ]*acpitables" | cut -c7->  $TMPLOG
> +$FWTS --log-format="%line %owner " -w 80 --dumpfile=acpidump-0001.log acpitables - | grep "^[0-9]*[ ]*acpitables" | cut -c7->  $TMPLOG
>   diff $TMPLOG acpitables-0001.log>>  $FAILURE_LOG
>   ret=$?
>   if [ $ret -eq 0 ]; then
Acked-by: Ivan Hu<ivan.hu@canonical.com>

Patch

diff --git a/acpitables-0007/acpitables-0001.log b/acpitables-0007/acpitables-0001.log
index 9001c4c..539e50e 100644
--- a/acpitables-0007/acpitables-0001.log
+++ b/acpitables-0007/acpitables-0001.log
@@ -1,5 +1,5 @@ 
 acpitables      ACPI table settings sanity checks.
-acpitables      ---------------------------------------------------------
+acpitables      ----------------------------------------------------------
 acpitables      Test 1 of 1: Check ACPI tables.
 acpitables      Table APIC not present to check.
 acpitables      Table ECDT not present to check.
@@ -122,7 +122,7 @@  acpitables      this will cause the kernel to oops, at best the kernel may
 acpitables      ignore this. However, it should be fixed where possible.
 acpitables      
 acpitables      
-acpitables      =========================================================
+acpitables      ==========================================================
 acpitables      2 passed, 14 failed, 0 warnings, 0 aborted, 0 skipped, 0
 acpitables      info only.
-acpitables      =========================================================
+acpitables      ==========================================================
diff --git a/acpitables-0007/test-0001.sh b/acpitables-0007/test-0001.sh
index 5bdc106..770a8d3 100755
--- a/acpitables-0007/test-0001.sh
+++ b/acpitables-0007/test-0001.sh
@@ -4,7 +4,7 @@  TEST="Test apcitables against broken ACPI XSDT table"
 NAME=test-0001.sh
 TMPLOG=$TMP/acpitables.log.$$
 
-$FWTS -w 80 --dumpfile=acpidump-0001.log acpitables - | grep "^[0-9]*[ ]*acpitables" | cut -c7- > $TMPLOG
+$FWTS --log-format="%line %owner " -w 80 --dumpfile=acpidump-0001.log acpitables - | grep "^[0-9]*[ ]*acpitables" | cut -c7- > $TMPLOG
 diff $TMPLOG acpitables-0001.log >> $FAILURE_LOG
 ret=$?
 if [ $ret -eq 0 ]; then