Patchwork [uClinux-dev] mtd: clean up uclinux.c map driver

login
register
mail settings
Submitter Artem Bityutskiy
Date May 16, 2012, 9:28 a.m.
Message ID <1337160532.24809.28.camel@sauron.fi.intel.com>
Download mbox | patch
Permalink /patch/159555/
State New
Headers show

Comments

Artem Bityutskiy - May 16, 2012, 9:28 a.m.
On Tue, 2012-05-15 at 11:57 -0400, Mike Frysinger wrote:
> On Tue, May 15, 2012 at 12:08 AM,  <gerg@snapgear.com> wrote:
> > . make the struct uclinux_ram_map static
> 
> NAK: this breaks Blackfin systems.  we specifically don't want this to
> be static.
> 
> it should probably get a comment added above it saying as much.

I've just amended that patch and made it non-static as well. But this is
really ugly dependency.

Patch

diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index ad75346..d8aa6df 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -21,7 +21,7 @@ 
 
 extern char _ebss;
 
-static struct map_info uclinux_ram_map = {
+struct map_info uclinux_ram_map = {
        .name = "RAM",
        .phys = (unsigned long)&_ebss,
        .size = 0,