Patchwork pci: aspm: make functions static

login
register
mail settings
Submitter Colin King
Date May 15, 2012, 7:05 p.m.
Message ID <1337108726-4713-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/159416/
State Accepted
Headers show

Comments

Colin King - May 15, 2012, 7:05 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/pci/aspm/aspm.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Alex Hung - May 16, 2012, 2:56 a.m.
On 05/16/2012 03:05 AM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/pci/aspm/aspm.c |   10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
> index fe6cb60..e85be9a 100644
> --- a/src/pci/aspm/aspm.c
> +++ b/src/pci/aspm/aspm.c
> @@ -114,9 +114,9 @@ static int facp_get_aspm_control(fwts_framework *fw, int *aspm)
>   	return FWTS_OK;
>   }
>
> -int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
> -					    struct pci_device *rp,
> -					    struct pci_device *dev)
> +static int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
> +	struct pci_device *rp,
> +	struct pci_device *dev)
>   {
>   	struct pcie_capability *rp_cap, *device_cap;
>   	uint8_t rp_aspm_cntrl, device_aspm_cntrl;
> @@ -199,8 +199,8 @@ static void pci_device_list_free(struct pci_device *head)
>   	}
>   }
>
> -int pcie_check_aspm_registers(fwts_framework *fw,
> -				   const fwts_log_level level)
> +static int pcie_check_aspm_registers(fwts_framework *fw,
> +	const fwts_log_level level)
>   {
>   	fwts_list *lspci_output;
>   	fwts_list_link *item;

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - May 17, 2012, 6:13 a.m.
On Wed, May 16, 2012 at 10:56 AM, Alex Hung <alex.hung@canonical.com> wrote:
> On 05/16/2012 03:05 AM, Colin King wrote:
>>
>> From: Colin Ian King<colin.king@canonical.com>
>>
>> Signed-off-by: Colin Ian King<colin.king@canonical.com>
>> ---
>>  src/pci/aspm/aspm.c |   10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
>> index fe6cb60..e85be9a 100644
>> --- a/src/pci/aspm/aspm.c
>> +++ b/src/pci/aspm/aspm.c
>> @@ -114,9 +114,9 @@ static int facp_get_aspm_control(fwts_framework *fw,
>> int *aspm)
>>        return FWTS_OK;
>>  }
>>
>> -int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
>> -                                           struct pci_device *rp,
>> -                                           struct pci_device *dev)
>> +static int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
>> +       struct pci_device *rp,
>> +       struct pci_device *dev)
>>  {
>>        struct pcie_capability *rp_cap, *device_cap;
>>        uint8_t rp_aspm_cntrl, device_aspm_cntrl;
>> @@ -199,8 +199,8 @@ static void pci_device_list_free(struct pci_device
>> *head)
>>        }
>>  }
>>
>> -int pcie_check_aspm_registers(fwts_framework *fw,
>> -                                  const fwts_log_level level)
>> +static int pcie_check_aspm_registers(fwts_framework *fw,
>> +       const fwts_log_level level)
>>  {
>>        fwts_list *lspci_output;
>>        fwts_list_link *item;
>
>
> Acked-by: Alex Hung <alex.hung@canonical.com>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - May 17, 2012, 10:13 a.m.
On 05/17/2012 02:13 PM, Keng-Yu Lin wrote:
> On Wed, May 16, 2012 at 10:56 AM, Alex Hung<alex.hung@canonical.com>  wrote:
>> On 05/16/2012 03:05 AM, Colin King wrote:
>>> From: Colin Ian King<colin.king@canonical.com>
>>>
>>> Signed-off-by: Colin Ian King<colin.king@canonical.com>
>>> ---
>>>   src/pci/aspm/aspm.c |   10 +++++-----
>>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
>>> index fe6cb60..e85be9a 100644
>>> --- a/src/pci/aspm/aspm.c
>>> +++ b/src/pci/aspm/aspm.c
>>> @@ -114,9 +114,9 @@ static int facp_get_aspm_control(fwts_framework *fw,
>>> int *aspm)
>>>         return FWTS_OK;
>>>   }
>>>
>>> -int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
>>> -                                           struct pci_device *rp,
>>> -                                           struct pci_device *dev)
>>> +static int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
>>> +       struct pci_device *rp,
>>> +       struct pci_device *dev)
>>>   {
>>>         struct pcie_capability *rp_cap, *device_cap;
>>>         uint8_t rp_aspm_cntrl, device_aspm_cntrl;
>>> @@ -199,8 +199,8 @@ static void pci_device_list_free(struct pci_device
>>> *head)
>>>         }
>>>   }
>>>
>>> -int pcie_check_aspm_registers(fwts_framework *fw,
>>> -                                  const fwts_log_level level)
>>> +static int pcie_check_aspm_registers(fwts_framework *fw,
>>> +       const fwts_log_level level)
>>>   {
>>>         fwts_list *lspci_output;
>>>         fwts_list_link *item;
>>
>> Acked-by: Alex Hung<alex.hung@canonical.com>
>>
> Acked-by: Keng-Yu Lin<kengyu@canonical.com>
>
Acked-by: Ivan Hu<ivan.hu@canonical.com>

Patch

diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
index fe6cb60..e85be9a 100644
--- a/src/pci/aspm/aspm.c
+++ b/src/pci/aspm/aspm.c
@@ -114,9 +114,9 @@  static int facp_get_aspm_control(fwts_framework *fw, int *aspm)
 	return FWTS_OK;
 }
 
-int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
-					    struct pci_device *rp,
-					    struct pci_device *dev)
+static int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw,
+	struct pci_device *rp,
+	struct pci_device *dev)
 {
 	struct pcie_capability *rp_cap, *device_cap;
 	uint8_t rp_aspm_cntrl, device_aspm_cntrl;
@@ -199,8 +199,8 @@  static void pci_device_list_free(struct pci_device *head)
 	}
 }
 
-int pcie_check_aspm_registers(fwts_framework *fw,
-				   const fwts_log_level level)
+static int pcie_check_aspm_registers(fwts_framework *fw,
+	const fwts_log_level level)
 {
 	fwts_list *lspci_output;
 	fwts_list_link *item;