From patchwork Tue May 15 15:06:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohammed Afzal X-Patchwork-Id: 159365 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 242F8B6FBE for ; Wed, 16 May 2012 01:08:52 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SUJL4-0004lW-1e; Tue, 15 May 2012 15:07:02 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SUJKv-0004hS-LX for linux-mtd@lists.infradead.org; Tue, 15 May 2012 15:06:54 +0000 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id q4FF6jS7013745; Tue, 15 May 2012 10:06:46 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q4FF6iqg029942; Tue, 15 May 2012 20:36:44 +0530 (IST) Received: from DBDE01.ent.ti.com ([fe80::d5df:c4b5:9919:4e10]) by DBDE70.ent.ti.com ([fe80::2141:513f:409:315a%21]) with mapi id 14.01.0323.003; Tue, 15 May 2012 20:36:44 +0530 From: "Mohammed, Afzal" To: "tony@atomide.com" , "dwmw2@infradead.org" , "artem.bityutskiy@linux.intel.com" , "dedekind1@gmail.com" , "linux-omap@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: RE: [PATCH 1/3] ARM: OMAP2+: gpmc: Modify interrupt handling Thread-Topic: [PATCH 1/3] ARM: OMAP2+: gpmc: Modify interrupt handling Thread-Index: AQHNMqkvnJK9AzwgOEG35QKG4EMF6ZbKlyfA Date: Tue, 15 May 2012 15:06:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -6.9 (------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-6.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [198.47.26.152 listed in list.dnswl.org] -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "ivan.djelic@parrot.com" X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi Tony, On Tue, May 15, 2012 at 20:08:34, Mohammed, Afzal wrote: > Modify interrupt handling such that interrupts can be handled by GPMC > client drivers using standard interrupt APIs rather than requiring > the drivers to have knowledge about GPMC interrupt handling. Currently > only NAND related interrupts has been considered (which is the case > even without this change) as the only user of GPMC interrupt is NAND. : > - ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL); If this series could not be considered for 3.5, to prevent failure of request_irq, either, 355f8ee ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse, should be avoided, or diff [1] would be required, as shared irq needs dev-id. Regards Afzal [1] diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 46b09da..9e1b726 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -768,7 +768,7 @@ static int __init gpmc_init(void) irq++; } - ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL); + ret = request_irq(gpmc_irq, gpmc_handle_irq, 0, "gpmc", NULL); if (ret) pr_err("gpmc: irq-%d could not claim: err %d\n", gpmc_irq, ret);