Patchwork sparc: Kill mmu_{un,}lockarea().

login
register
mail settings
Submitter David Miller
Date May 15, 2012, 4:04 a.m.
Message ID <20120515.000401.965386011845784393.davem@davemloft.net>
Download mbox | patch
Permalink /patch/159224/
State Accepted
Delegated to: David Miller
Headers show

Comments

David Miller - May 15, 2012, 4:04 a.m.
From: Josip Rodin <joy@entuzijast.net>
Date: Mon, 14 May 2012 09:48:44 +0200

> On Sun, May 13, 2012 at 04:28:32PM -0400, David Miller wrote:
>> --- a/arch/sparc/include/asm/floppy_64.h
>> +++ b/arch/sparc/include/asm/floppy_64.h
>> @@ -194,7 +191,7 @@ static void sun_fd_set_dma_count(int length)
>>  
>>  static void sun_fd_enable_dma(void)
>>  {
>> -	pdma_vaddr = mmu_lockarea(pdma_vaddr, pdma_size);
>> +	pdma_vaddr = pdma_vaddr;
> 
>> -#define mmu_lockarea(vaddr, len)		(vaddr)
> 
> Drop the first changed line entirely? I see it was effectively there before,
> but still :)

Yeah that's pretty pointless, fixed thusly :-)

--------------------
[PATCH] sparc64: Remove pointless assignment in floppy support.

Reported-by: Josip Rodin <joy@entuzijast.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/include/asm/floppy_64.h |    1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/arch/sparc/include/asm/floppy_64.h b/arch/sparc/include/asm/floppy_64.h
index d534c27..e204f90 100644
--- a/arch/sparc/include/asm/floppy_64.h
+++ b/arch/sparc/include/asm/floppy_64.h
@@ -191,7 +191,6 @@  static void sun_fd_set_dma_count(int length)
 
 static void sun_fd_enable_dma(void)
 {
-	pdma_vaddr = pdma_vaddr;
 	pdma_base = pdma_vaddr;
 	pdma_areasize = pdma_size;
 }