Patchwork net/bridge/netfilter: Fix the randconfig warning

login
register
mail settings
Submitter Devendra Naga
Date May 14, 2012, 7:30 p.m.
Message ID <1337023817-26132-1-git-send-email-devendra.aaru@gmail.com>
Download mbox | patch
Permalink /patch/159130/
State Not Applicable
Headers show

Comments

Devendra Naga - May 14, 2012, 7:30 p.m.
when ran with make randconfig got

warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)

added NET && INET && NETFILTER dependency to the BRIDGE_NF_EBTABLES

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
 net/bridge/netfilter/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Bart De Schuymer - May 17, 2012, 7:21 a.m.
Op 14/05/2012 21:30, Devendra Naga schreef:
> when ran with make randconfig got
>
> warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET&&  INET&&  NETFILTER)
>
> added NET&&  INET&&  NETFILTER dependency to the BRIDGE_NF_EBTABLES

I really don't see why ebtables should depend on INET. To me the issue 
lies in the fact that xtables depends on INET.

Bart

Patch

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index a9aff9c..34f6d9d 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -4,7 +4,7 @@ 
 
 menuconfig BRIDGE_NF_EBTABLES
 	tristate "Ethernet Bridge tables (ebtables) support"
-	depends on BRIDGE && NETFILTER
+	depends on NET && INET && BRIDGE && NETFILTER
 	select NETFILTER_XTABLES
 	help
 	  ebtables is a general, extensible frame/packet identification