| Message ID | 1337016017-30537-1-git-send-email-swarren@wwwdotorg.org |
|---|---|
| State | New |
| Headers | show |
On Monday 14 May 2012, Stephen Warren wrote:
> This is some late device tree additions and cleanup for Tegra.
Hi Stephen,
The log you sent there does not match what I got. These are the changes I got
from pulling your tree:
ARM: dt: tegra: invert status=disable vs status=okay
ARM: dt: tegra: consistent basic property ordering
ARM: dt: tegra: sort nodes based on bus order
ARM: dt: tegra: remove duplicate device_type property
ARM: dt: tegra: consistenly use lower-case for hex constants
ARM: dt: tegra: format regs properties consistently
ARM: dt: tegra: gpio comment cleanup
ARM: dt: tegra: remove unnecessary unit addresses
ARM: dt: tegra: whitespace cleanup
ARM: dt: tegra cardhu: fix typo in SDHCI node name
ARM: dt: tegra: cardhu: register core regulator tps62361
ARM: dt: tegra30.dtsi: Add SMMU node
ARM: dt: tegra20.dtsi: Add GART node
ARM: dt: tegra30.dtsi: Add Memory Controller(MC) nodes
ARM: dt: tegra20.dtsi: Add Memory Controller(MC) nodes
ARM: dt: tegra: Add device tree support for AHB
arch/arm/boot/dts/tegra-cardhu.dts | 77 +++++++-----------
arch/arm/boot/dts/tegra-harmony.dts | 100 +++++++++++------------
arch/arm/boot/dts/tegra-paz00.dts | 112 ++++++++++++-------------
arch/arm/boot/dts/tegra-seaboard.dts | 176 +++++++++++++++++++---------------------
arch/arm/boot/dts/tegra-trimslice.dts | 71 +++++++---------
arch/arm/boot/dts/tegra-ventana.dts | 90 ++++++++++-----------
arch/arm/boot/dts/tegra20.dtsi | 275 +++++++++++++++++++++++++++++++++++---------------------------
arch/arm/boot/dts/tegra30.dtsi | 292 ++++++++++++++++++++++++++++++++++++++----------------------------
8 files changed, 605 insertions(+), 588 deletions(-)
I can't see anything wrong with your commits but please check again that it all makes
sense and let me know if I should really pull this version.
Arnd
On Monday 14 May 2012, Stephen Warren wrote: > A late tegra_defconfig change to add a regulator for Cardhu. > > This is based on the for-3.5/defconfig branch in the Tegra repo, which > is already merged into arm-soc. > > ---------------------------------------------------------------- > > The following changes since commit c6b556a53970c262571b2cf60661a33ddeb1a651: > > ARM: tegra: update defconfig > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git for-3.5/defconfig2 > > for you to fetch changes up to 06d96e1e6dbdcc88d20b21cc54ee8388c074f47f: > Pulled, thanks! Arnd
On 05/14/2012 12:54 PM, Arnd Bergmann wrote: > On Monday 14 May 2012, Stephen Warren wrote: >> This is some late device tree additions and cleanup for Tegra. > > Hi Stephen, > > The log you sent there does not match what I got. These are the changes I got > from pulling your tree: > > ARM: dt: tegra: invert status=disable vs status=okay > ARM: dt: tegra: consistent basic property ordering > ARM: dt: tegra: sort nodes based on bus order > ARM: dt: tegra: remove duplicate device_type property > ARM: dt: tegra: consistenly use lower-case for hex constants > ARM: dt: tegra: format regs properties consistently > ARM: dt: tegra: gpio comment cleanup > ARM: dt: tegra: remove unnecessary unit addresses > ARM: dt: tegra: whitespace cleanup > ARM: dt: tegra cardhu: fix typo in SDHCI node name > ARM: dt: tegra: cardhu: register core regulator tps62361 > ARM: dt: tegra30.dtsi: Add SMMU node > ARM: dt: tegra20.dtsi: Add GART node > ARM: dt: tegra30.dtsi: Add Memory Controller(MC) nodes > ARM: dt: tegra20.dtsi: Add Memory Controller(MC) nodes > ARM: dt: tegra: Add device tree support for AHB Those look good. I assume the problem is in the diffstat not the log... > arch/arm/boot/dts/tegra-cardhu.dts | 77 +++++++----------- > arch/arm/boot/dts/tegra-harmony.dts | 100 +++++++++++------------ > arch/arm/boot/dts/tegra-paz00.dts | 112 ++++++++++++------------- > arch/arm/boot/dts/tegra-seaboard.dts | 176 +++++++++++++++++++--------------------- > arch/arm/boot/dts/tegra-trimslice.dts | 71 +++++++--------- > arch/arm/boot/dts/tegra-ventana.dts | 90 ++++++++++----------- > arch/arm/boot/dts/tegra20.dtsi | 275 +++++++++++++++++++++++++++++++++++--------------------------- > arch/arm/boot/dts/tegra30.dtsi | 292 ++++++++++++++++++++++++++++++++++++++---------------------------- > 8 files changed, 605 insertions(+), 588 deletions(-) > > I can't see anything wrong with your commits but please check again that it all makes > sense and let me know if I should really pull this version. I think that looks OK. I probably just generated the diffstat backwards. I ran: git diff -M --stat=75 --summary $TIP_SHA..$BASE_SHA Perhaps I should have run: git diff -M --stat=75 --summary $BASE_SHA..$TIP_SHA where BASE_SHA is the merge the branch was based on, and TIP_SHA is the latest commit in the branch.
On 05/14/2012 02:37 PM, Arnd Bergmann wrote: > On Monday 14 May 2012, Stephen Warren wrote: >> On 05/14/2012 12:54 PM, Arnd Bergmann wrote: > >>> >>> I can't see anything wrong with your commits but please check again that it all makes >>> sense and let me know if I should really pull this version. >> >> I think that looks OK. I probably just generated the diffstat backwards. > > Ok, thanks for the confirmation. > > I've pulled it into next/dt2 now. In order to merge this with the drivers/mmc branch > that contains the common mmc binding, I used the complex resolution below, adding > bus-width properties to both the dtsi and the dts files. Yeah, sorry about those conflicts. Thanks for fixing them up. The changes to tegra-*.dts look fine. I wonder if the changes to tegra-*.dtsi shouldn't just be dropped? I'd personally err on the side of requiring board files to add this property, rather than having things accidentally work because the .dtsi file included a default. BTW, I assume that in 3.6, I should plan to remove the support-8bit properties and associated Tegra SDHCI driver code that handles them, and rely on the SDHCI core handling this from now on?
On Monday 14 May 2012, Stephen Warren wrote: > I wonder if the changes to tegra-*.dtsi shouldn't just be dropped? I'd > personally err on the side of requiring board files to add this > property, rather than having things accidentally work because the .dtsi > file included a default. I ended up redoing the merge because I found an embarrasing typo in my patch and now dropped the property for the dtsi files. > BTW, I assume that in 3.6, I should plan to remove the support-8bit > properties and associated Tegra SDHCI driver code that handles them, and > rely on the SDHCI core handling this from now on? I think we can't drop it from the driver because of existing powerpc machines providing the property, but it would be ok if you drop it from your .dts files. Arnd
On 05/15/2012 05:43 AM, Arnd Bergmann wrote: > On Monday 14 May 2012, Stephen Warren wrote: >> I wonder if the changes to tegra-*.dtsi shouldn't just be dropped? I'd >> personally err on the side of requiring board files to add this >> property, rather than having things accidentally work because the .dtsi >> file included a default. > > I ended up redoing the merge because I found an embarrasing typo in my patch > and now dropped the property for the dtsi files. > >> BTW, I assume that in 3.6, I should plan to remove the support-8bit >> properties and associated Tegra SDHCI driver code that handles them, and >> rely on the SDHCI core handling this from now on? > > I think we can't drop it from the driver because of existing powerpc machines > providing the property, but it would be ok if you drop it from your .dts > files. support-8bit is parsed by the Tegra driver only, and only appears in tegra-*.dts across all arch/*/boot.dts. I assume you were talking about some other property, although I can't tell which from a very quick look at arch/powerpc/boot/dts/*.
On Tuesday 15 May 2012, Stephen Warren wrote: > > I think we can't drop it from the driver because of existing powerpc machines > > providing the property, but it would be ok if you drop it from your .dts > > files. > > support-8bit is parsed by the Tegra driver only, and only appears in > tegra-*.dts across all arch/*/boot.dts. I assume you were talking about > some other property, although I can't tell which from a very quick look > at arch/powerpc/boot/dts/*. Right, my mistake. I guess we could have just removed it right away then. Arnd
On 05/15/2012 01:15 PM, Arnd Bergmann wrote: > On Tuesday 15 May 2012, Stephen Warren wrote: >>> I think we can't drop it from the driver because of existing powerpc machines >>> providing the property, but it would be ok if you drop it from your .dts >>> files. >> >> support-8bit is parsed by the Tegra driver only, and only appears in >> tegra-*.dts across all arch/*/boot.dts. I assume you were talking about >> some other property, although I can't tell which from a very quick look >> at arch/powerpc/boot/dts/*. > > Right, my mistake. > > I guess we could have just removed it right away then. No worries. I'll take an action to do this in 3.6. Thanks for cleaning up the bindings.