Patchwork [google/gcc-4_6] Backport arm hardfp patch from trunk (issue 6206055)

login
register
mail settings
Submitter Han Shen
Date May 14, 2012, 5:16 p.m.
Message ID <0016e68fd01895c96804c00240cb@google.com>
Download mbox | patch
Permalink /patch/159075/
State New
Headers show

Comments

Han Shen - May 14, 2012, 5:16 p.m.
On 2012/05/11 22:15:37, carrot wrote:
> http://codereview.appspot.com/6206055/diff/4001/gcc/ChangeLog
> File gcc/ChangeLog (right):


http://codereview.appspot.com/6206055/diff/4001/gcc/ChangeLog#newcode11
> gcc/ChangeLog:11:
> It seems you also merged in another patch r187012, please mention it.


http://codereview.appspot.com/6206055/diff/4001/gcc/config/arm/linux-eabi.h
> File gcc/config/arm/linux-eabi.h (right):


http://codereview.appspot.com/6206055/diff/4001/gcc/config/arm/linux-eabi.h#newcode77
> gcc/config/arm/linux-eabi.h:77: RUNTIME_ROOT_PREFIX
> GLIBC_DYNAMIC_LINKER_SOFT_FLOAT

> Here the RUNTIME_ROOT_PREFIX may be redundant.

Hi Carrot, thanks!

Modified per your comments.


@@ -59,10 +60,25 @@
  #undef  SUBTARGET_EXTRA_LINK_SPEC
  #define SUBTARGET_EXTRA_LINK_SPEC " -m " TARGET_LINKER_EMULATION

-/* Use ld-linux.so.3 so that it will be possible to run "classic"
-   GNU/Linux binaries on an EABI system.  */
+/* GNU/Linux on ARM currently supports three dynamic linkers:
+   - ld-linux.so.2 - for the legacy ABI
+   - ld-linux.so.3 - for the EABI-derived soft-float ABI
+   - ld-linux-armhf.so.3 - for the EABI-derived hard-float ABI.
+   All the dynamic linkers live in /lib.
+   We default to soft-float, but this can be overridden by changing
both
+   GLIBC_DYNAMIC_LINKER_DEFAULT and TARGET_DEFAULT_FLOAT_ABI.  */
+
  #undef  GLIBC_DYNAMIC_LINKER
-#define GLIBC_DYNAMIC_LINKER RUNTIME_ROOT_PREFIX "/lib/ld-linux.so.3"
+#define GLIBC_DYNAMIC_LINKER_SOFT_FLOAT \
+  RUNTIME_ROOT_PREFIX "/lib/ld-linux.so.3"
+#define GLIBC_DYNAMIC_LINKER_HARD_FLOAT \
+  RUNTIME_ROOT_PREFIX "/lib/ld-linux-armhf.so.3"
+#define GLIBC_DYNAMIC_LINKER_DEFAULT GLIBC_DYNAMIC_LINKER_SOFT_FLOAT
+
+#define GLIBC_DYNAMIC_LINKER \
+   "%{mfloat-abi=hard:" GLIBC_DYNAMIC_LINKER_HARD_FLOAT "} \
+    %{mfloat-abi=soft*:" GLIBC_DYNAMIC_LINKER_SOFT_FLOAT "} \
+    %{!mfloat-abi=*:" GLIBC_DYNAMIC_LINKER_DEFAULT "}"

  /* At this point, bpabi.h will have clobbered LINK_SPEC.  We want to
     use the GNU/Linux version, not the generic BPABI version.  */
=============

http://codereview.appspot.com/6206055/

Patch

========= Patch start

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 2f85855..afe7769 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,19 @@ 
+2012-05-11  Han Shen  <shenhan@google.com>
+
+	Backport from mainline.
+	2012-05-01  Richard Earnshaw  <rearnsha@arm.com>
+
+	* arm/linux-eabi.h (GLIBC_DYNAMIC_LINKER_DEFAULT): Avoid ifdef
+	comparing enumeration values.  Update comments.
+
+	2012-04-26  Michael Hope  <michael.hope@linaro.org>
+		    Richard Earnshaw  <rearnsha@arm.com>
+
+	* config/arm/linux-eabi.h (GLIBC_DYNAMIC_LINKER_SOFT_FLOAT): Define.
+	(GLIBC_DYNAMIC_LINKER_HARD_FLOAT): Define.
+	(GLIBC_DYNAMIC_LINKER_DEFAULT): Define.
+	(GLIBC_DYNAMIC_LINKER):	Redefine to use the hard float path.
+
  2012-04-30  Uros Bizjak  <ubizjak@gmail.com>

  	Backport from mainline
diff --git a/gcc/config/arm/linux-eabi.h b/gcc/config/arm/linux-eabi.h
index 3a32188..e1d3415 100644
--- a/gcc/config/arm/linux-eabi.h
+++ b/gcc/config/arm/linux-eabi.h
@@ -32,7 +32,8 @@ 
    while (false)

  /* We default to a soft-float ABI so that binaries can run on all
-   target hardware.  */
+   target hardware.  If you override this to use the hard-float ABI
then
+   change the setting of GLIBC_DYNAMIC_LINKER_DEFAULT as well.  */
  #undef  TARGET_DEFAULT_FLOAT_ABI
  #define TARGET_DEFAULT_FLOAT_ABI ARM_FLOAT_ABI_SOFT