From patchwork Mon May 14 17:12:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 159071 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A2478B703C for ; Tue, 15 May 2012 03:13:26 +1000 (EST) Received: from localhost ([::1]:54859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STypo-0001XG-DQ for incoming@patchwork.ozlabs.org; Mon, 14 May 2012 13:13:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STypc-0001Vg-KV for qemu-devel@nongnu.org; Mon, 14 May 2012 13:13:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STypa-00020b-VX for qemu-devel@nongnu.org; Mon, 14 May 2012 13:13:12 -0400 Received: from smtp.citrix.com ([66.165.176.89]:62459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STypa-00020M-Qj for qemu-devel@nongnu.org; Mon, 14 May 2012 13:13:10 -0400 X-IronPort-AV: E=Sophos;i="4.75,588,1330923600"; d="scan'208";a="25163566" Received: from ftlpmailmx01.citrite.net ([10.13.107.65]) by FTLPIPO01.CITRIX.COM with ESMTP/TLS/RC4-MD5; 14 May 2012 13:13:08 -0400 Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.65) with Microsoft SMTP Server id 8.3.213.0; Mon, 14 May 2012 13:13:07 -0400 Received: from kaball.uk.xensource.com ([10.80.2.59] helo=localhost.localdomain) by ukmail1.uk.xensource.com with esmtp (Exim 4.69) (envelope-from ) id 1STypS-0006xv-Cc; Mon, 14 May 2012 18:13:02 +0100 From: Stefano Stabellini To: qemu-devel@nongnu.org Date: Mon, 14 May 2012 18:12:59 +0100 Message-ID: <1337015581-15996-3-git-send-email-stefano.stabellini@eu.citrix.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.89 Cc: xen-devel@lists.xensource.com, Stefano Stabellini Subject: [Qemu-devel] [PATCH 1.1 v2 3/5] xen_disk: remove syncwrite option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch removes a dead option. The same can be achieved removing BDRV_O_NOCACHE and BDRV_O_CACHE_WB from the flags passed to bdrv_open. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 22dbd10..49e53b7 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -48,7 +48,6 @@ /* ------------------------------------------------------------- */ -static int syncwrite = 0; static int batch_maps = 0; static int max_requests = 32; @@ -189,15 +188,10 @@ static int ioreq_parse(struct ioreq *ioreq) ioreq->presync = 1; return 0; } - if (!syncwrite) { - ioreq->presync = ioreq->postsync = 1; - } + ioreq->presync = ioreq->postsync = 1; /* fall through */ case BLKIF_OP_WRITE: ioreq->prot = PROT_READ; /* from memory */ - if (syncwrite) { - ioreq->postsync = 1; - } break; default: xen_be_printf(&blkdev->xendev, 0, "error: unknown operation (%d)\n",