Patchwork [U-Boot,1/6,V4] EXYNOS5: Fix system register structure

login
register
mail settings
Submitter Rajeshwari Birje
Date May 14, 2012, 3:52 p.m.
Message ID <1337010725-24807-1-git-send-email-rajeshwari.s@samsung.com>
Download mbox | patch
Permalink /patch/159045/
State Accepted
Headers show

Comments

Rajeshwari Birje - May 14, 2012, 3:52 p.m.
This patch corrects the SYSREG structure.
We have removed the sysreg.h added in the previous patchset
version as the sysreg structure is already defined in system.h.

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
Acked-by: Minkyu Kang <mk7.kang@samsung.com>
---
 arch/arm/include/asm/arch-exynos/system.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Marek Vasut - May 14, 2012, 6:26 p.m.
Dear Rajeshwari Shinde,

> This patch corrects the SYSREG structure.

What is the exact difference between this patchset and V3 one? It's a good 
practice to sum such things up below diffstat.

> We have removed the sysreg.h added in the previous patchset
> version as the sysreg structure is already defined in system.h.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  arch/arm/include/asm/arch-exynos/system.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-exynos/system.h
> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
> --- a/arch/arm/include/asm/arch-exynos/system.h
> +++ b/arch/arm/include/asm/arch-exynos/system.h
> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>  	unsigned int	reserved;
>  	unsigned int	ispblk_cfg;
>  	unsigned int	usb20phy_cfg;
> +	unsigned char	res2[0x29c];
>  	unsigned int	mipi_dphy;
>  	unsigned int	dptx_dphy;
>  	unsigned int	phyclk_sel;

Best regards,
Marek Vasut
Vivek Gautam - May 16, 2012, 12:02 p.m.
Hi Marek,

On Wed, May 14, 2012 at 11:56 PM, Marek Vasut
<marex@denx.de<chander.kashyap@linaro.org>
> wrote:

> Dear Rajeshwari Shinde,
>
> > This patch corrects the SYSREG structure.
>
> What is the exact difference between this patchset and V3 one? It's a good
> practice to sum such things up below diffstat.
>

Yes,
Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI,
and mentioned in the same.

>
> > We have removed the sysreg.h added in the previous patchset
> > version as the sysreg structure is already defined in system.h.
> >
> > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> > Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> >  arch/arm/include/asm/arch-exynos/system.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/arch-exynos/system.h
> > b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
> > --- a/arch/arm/include/asm/arch-exynos/system.h
> > +++ b/arch/arm/include/asm/arch-exynos/system.h
> > @@ -42,6 +42,7 @@ struct exynos5_sysreg {
> >       unsigned int    reserved;
> >       unsigned int    ispblk_cfg;
> >       unsigned int    usb20phy_cfg;
> > +     unsigned char   res2[0x29c];
> >       unsigned int    mipi_dphy;
> >       unsigned int    dptx_dphy;
> >       unsigned int    phyclk_sel;
>
> Best regards,
> Marek Vasut
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
> --
> with warm regards,
> Chander Kashyap
>
Best regards
Vivek Gautam
Marek Vasut - May 16, 2012, 1:23 p.m.
Dear Vivek Gautam,

> Hi Marek,
> 
> On Wed, May 14, 2012 at 11:56 PM, Marek Vasut
> <marex@denx.de<chander.kashyap@linaro.org>
> 
> > wrote:
> > 
> > Dear Rajeshwari Shinde,
> > 
> > > This patch corrects the SYSREG structure.
> > 
> > What is the exact difference between this patchset and V3 one? It's a
> > good practice to sum such things up below diffstat.
> 
> Yes,
> Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI,
> and mentioned in the same.

What exact change please?

> 
> > > We have removed the sysreg.h added in the previous patchset
> > > version as the sysreg structure is already defined in system.h.
> > > 
> > > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> > > Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> > > ---
> > > 
> > >  arch/arm/include/asm/arch-exynos/system.h |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/arch/arm/include/asm/arch-exynos/system.h
> > > b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f
> > > 100644 --- a/arch/arm/include/asm/arch-exynos/system.h
> > > +++ b/arch/arm/include/asm/arch-exynos/system.h
> > > @@ -42,6 +42,7 @@ struct exynos5_sysreg {
> > > 
> > >       unsigned int    reserved;
> > >       unsigned int    ispblk_cfg;
> > >       unsigned int    usb20phy_cfg;
> > > 
> > > +     unsigned char   res2[0x29c];
> > > 
> > >       unsigned int    mipi_dphy;
> > >       unsigned int    dptx_dphy;
> > >       unsigned int    phyclk_sel;
> > 
> > Best regards,
> > Marek Vasut
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> > 
> > 
> > --
> > with warm regards,
> > Chander Kashyap
> 
> Best regards
> Vivek Gautam

Best regards,
Marek Vasut
Rajeshwari Birje - May 18, 2012, 5 a.m.
Hi Marek,

The exact change is in  "[PATCH 4/6 V4] EXYNOS: Add power
Enable/Disable for USB-EHCI",
It is : Renamed exynos5_set_usb_phy_ctrl and set_usb_phy_ctrl to
exynos5_set_usbhost_phy_ctrl and set_usbhost_phy_ctrl.

On Wed, May 16, 2012 at 6:53 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Vivek Gautam,
>
>> Hi Marek,
>>
>> On Wed, May 14, 2012 at 11:56 PM, Marek Vasut
>> <marex@denx.de<chander.kashyap@linaro.org>
>>
>> > wrote:
>> >
>> > Dear Rajeshwari Shinde,
>> >
>> > > This patch corrects the SYSREG structure.
>> >
>> > What is the exact difference between this patchset and V3 one? It's a
>> > good practice to sum such things up below diffstat.
>>
>> Yes,
>> Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for USB-EHCI,
>> and mentioned in the same.
>
> What exact change please?
>
>>
>> > > We have removed the sysreg.h added in the previous patchset
>> > > version as the sysreg structure is already defined in system.h.
>> > >
>> > > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> > > Acked-by: Minkyu Kang <mk7.kang@samsung.com>
>> > > ---
>> > >
>> > >  arch/arm/include/asm/arch-exynos/system.h |    1 +
>> > >  1 files changed, 1 insertions(+), 0 deletions(-)
>> > >
>> > > diff --git a/arch/arm/include/asm/arch-exynos/system.h
>> > > b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f
>> > > 100644 --- a/arch/arm/include/asm/arch-exynos/system.h
>> > > +++ b/arch/arm/include/asm/arch-exynos/system.h
>> > > @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>> > >
>> > >       unsigned int    reserved;
>> > >       unsigned int    ispblk_cfg;
>> > >       unsigned int    usb20phy_cfg;
>> > >
>> > > +     unsigned char   res2[0x29c];
>> > >
>> > >       unsigned int    mipi_dphy;
>> > >       unsigned int    dptx_dphy;
>> > >       unsigned int    phyclk_sel;
>> >
>> > Best regards,
>> > Marek Vasut
>> > _______________________________________________
>> > U-Boot mailing list
>> > U-Boot@lists.denx.de
>> > http://lists.denx.de/mailman/listinfo/u-boot
>> >
>> >
>> > --
>> > with warm regards,
>> > Chander Kashyap
>>
>> Best regards
>> Vivek Gautam
>
> Best regards,
> Marek Vasut
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Regards,
Rajeshwari Shinde.
Marek Vasut - May 18, 2012, 10:59 a.m.
Dear Rajeshwari Birje,

> Hi Marek,
> 
> The exact change is in  "[PATCH 4/6 V4] EXYNOS: Add power
> Enable/Disable for USB-EHCI",
> It is : Renamed exynos5_set_usb_phy_ctrl and set_usb_phy_ctrl to
> exynos5_set_usbhost_phy_ctrl and set_usbhost_phy_ctrl.

Thank you for clearing this up. I'm now waiting for pullrq from albert to hit 
mainline.

> 
> On Wed, May 16, 2012 at 6:53 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Vivek Gautam,
> > 
> >> Hi Marek,
> >> 
> >> On Wed, May 14, 2012 at 11:56 PM, Marek Vasut
> >> <marex@denx.de<chander.kashyap@linaro.org>
> >> 
> >> > wrote:
> >> > 
> >> > Dear Rajeshwari Shinde,
> >> > 
> >> > > This patch corrects the SYSREG structure.
> >> > 
> >> > What is the exact difference between this patchset and V3 one? It's a
> >> > good practice to sum such things up below diffstat.
> >> 
> >> Yes,
> >> Change is in [PATCH 4/6 V4] EXYNOS: Add power Enable/Disable for
> >> USB-EHCI, and mentioned in the same.
> > 
> > What exact change please?
> > 
> >> > > We have removed the sysreg.h added in the previous patchset
> >> > > version as the sysreg structure is already defined in system.h.
> >> > > 
> >> > > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> >> > > Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> >> > > ---
> >> > > 
> >> > >  arch/arm/include/asm/arch-exynos/system.h |    1 +
> >> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> >> > > 
> >> > > diff --git a/arch/arm/include/asm/arch-exynos/system.h
> >> > > b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f
> >> > > 100644 --- a/arch/arm/include/asm/arch-exynos/system.h
> >> > > +++ b/arch/arm/include/asm/arch-exynos/system.h
> >> > > @@ -42,6 +42,7 @@ struct exynos5_sysreg {
> >> > > 
> >> > >       unsigned int    reserved;
> >> > >       unsigned int    ispblk_cfg;
> >> > >       unsigned int    usb20phy_cfg;
> >> > > 
> >> > > +     unsigned char   res2[0x29c];
> >> > > 
> >> > >       unsigned int    mipi_dphy;
> >> > >       unsigned int    dptx_dphy;
> >> > >       unsigned int    phyclk_sel;
> >> > 
> >> > Best regards,
> >> > Marek Vasut
> >> > _______________________________________________
> >> > U-Boot mailing list
> >> > U-Boot@lists.denx.de
> >> > http://lists.denx.de/mailman/listinfo/u-boot
> >> > 
> >> > 
> >> > --
> >> > with warm regards,
> >> > Chander Kashyap
> >> 
> >> Best regards
> >> Vivek Gautam
> > 
> > Best regards,
> > Marek Vasut
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> 
> Regards,
> Rajeshwari Shinde.

Best regards,
Marek Vasut
Marek Vasut - May 20, 2012, 6:35 a.m.
Dear Rajeshwari Shinde,

> This patch corrects the SYSREG structure.
> We have removed the sysreg.h added in the previous patchset
> version as the sysreg structure is already defined in system.h.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> Acked-by: Minkyu Kang <mk7.kang@samsung.com>

Applying: EXYNOS5: Fix system register structure
error: arch/arm/include/asm/arch-exynos/system.h: does not exist in index
Patch failed at 0001 EXYNOS5: Fix system register structure
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

The file is still missing for some reason ... still not mainline? I'm still 
having these patches here in the pipeline, sorry to keep you waiting, but I'm 
blocked here by another patch it seems.

I rolled out new u-boot-usb/master so you can rebase on top of it before 
resending (if necessary).

> ---
>  arch/arm/include/asm/arch-exynos/system.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-exynos/system.h
> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
> --- a/arch/arm/include/asm/arch-exynos/system.h
> +++ b/arch/arm/include/asm/arch-exynos/system.h
> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>  	unsigned int	reserved;
>  	unsigned int	ispblk_cfg;
>  	unsigned int	usb20phy_cfg;
> +	unsigned char	res2[0x29c];
>  	unsigned int	mipi_dphy;
>  	unsigned int	dptx_dphy;
>  	unsigned int	phyclk_sel;

Best regards,
Marek Vasut
Rajeshwari Birje - May 21, 2012, 5:27 a.m.
Hi Marek,

I am working on u-boot-samsung master branch.
arch/arm/include/asm/arch-exynos/system.h was added to it on April 5
2012 with patch:
"EXYNOS: definitions of system resgister and power management registers."

If you still want me rebase the patches on  u-boot-usb/master do let me know.

On Sun, May 20, 2012 at 12:05 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Rajeshwari Shinde,
>
>> This patch corrects the SYSREG structure.
>> We have removed the sysreg.h added in the previous patchset
>> version as the sysreg structure is already defined in system.h.
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
>
> Applying: EXYNOS5: Fix system register structure
> error: arch/arm/include/asm/arch-exynos/system.h: does not exist in index
> Patch failed at 0001 EXYNOS5: Fix system register structure
> When you have resolved this problem run "git am --resolved".
> If you would prefer to skip this patch, instead run "git am --skip".
> To restore the original branch and stop patching run "git am --abort".
>
> The file is still missing for some reason ... still not mainline? I'm still
> having these patches here in the pipeline, sorry to keep you waiting, but I'm
> blocked here by another patch it seems.
>
> I rolled out new u-boot-usb/master so you can rebase on top of it before
> resending (if necessary).
>
>> ---
>>  arch/arm/include/asm/arch-exynos/system.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/system.h
>> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
>> --- a/arch/arm/include/asm/arch-exynos/system.h
>> +++ b/arch/arm/include/asm/arch-exynos/system.h
>> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>>       unsigned int    reserved;
>>       unsigned int    ispblk_cfg;
>>       unsigned int    usb20phy_cfg;
>> +     unsigned char   res2[0x29c];
>>       unsigned int    mipi_dphy;
>>       unsigned int    dptx_dphy;
>>       unsigned int    phyclk_sel;
>
> Best regards,
> Marek Vasut
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Best regards,
Rajeshwari Shinde
Marek Vasut - May 21, 2012, 5:41 a.m.
Dear Rajeshwari Birje,

> Hi Marek,
> 
> I am working on u-boot-samsung master branch.
> arch/arm/include/asm/arch-exynos/system.h was added to it on April 5
> 2012 with patch:
> "EXYNOS: definitions of system resgister and power management registers."
> 
> If you still want me rebase the patches on  u-boot-usb/master do let me
> know.

Well that patch still isn't in u-boot/master, or am I wrong? Minkyu?

> 
> On Sun, May 20, 2012 at 12:05 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Rajeshwari Shinde,
> > 
> >> This patch corrects the SYSREG structure.
> >> We have removed the sysreg.h added in the previous patchset
> >> version as the sysreg structure is already defined in system.h.
> >> 
> >> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> >> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> > 
> > Applying: EXYNOS5: Fix system register structure
> > error: arch/arm/include/asm/arch-exynos/system.h: does not exist in index
> > Patch failed at 0001 EXYNOS5: Fix system register structure
> > When you have resolved this problem run "git am --resolved".
> > If you would prefer to skip this patch, instead run "git am --skip".
> > To restore the original branch and stop patching run "git am --abort".
> > 
> > The file is still missing for some reason ... still not mainline? I'm
> > still having these patches here in the pipeline, sorry to keep you
> > waiting, but I'm blocked here by another patch it seems.
> > 
> > I rolled out new u-boot-usb/master so you can rebase on top of it before
> > resending (if necessary).
> > 
> >> ---
> >>  arch/arm/include/asm/arch-exynos/system.h |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >> 
> >> diff --git a/arch/arm/include/asm/arch-exynos/system.h
> >> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f
> >> 100644 --- a/arch/arm/include/asm/arch-exynos/system.h
> >> +++ b/arch/arm/include/asm/arch-exynos/system.h
> >> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
> >>       unsigned int    reserved;
> >>       unsigned int    ispblk_cfg;
> >>       unsigned int    usb20phy_cfg;
> >> +     unsigned char   res2[0x29c];
> >>       unsigned int    mipi_dphy;
> >>       unsigned int    dptx_dphy;
> >>       unsigned int    phyclk_sel;
> > 
> > Best regards,
> > Marek Vasut
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> 
> Best regards,
> Rajeshwari Shinde

Best regards,
Marek Vasut
Anatolij Gustschin - May 21, 2012, 6:28 a.m.
Hi Marek,

On Mon, 21 May 2012 07:41:04 +0200
Marek Vasut <marex@denx.de> wrote:

> Dear Rajeshwari Birje,
> 
> > Hi Marek,
> > 
> > I am working on u-boot-samsung master branch.
> > arch/arm/include/asm/arch-exynos/system.h was added to it on April 5
> > 2012 with patch:
> > "EXYNOS: definitions of system resgister and power management registers."
> > 
> > If you still want me rebase the patches on  u-boot-usb/master do let me
> > know.
> 
> Well that patch still isn't in u-boot/master, or am I wrong? Minkyu?

Wolfgang merged ARM pull request yesterday, so it is in u-boot/master
now.

Thanks,
Anatolij

Patch

diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h
index c85f949..c1d880f 100644
--- a/arch/arm/include/asm/arch-exynos/system.h
+++ b/arch/arm/include/asm/arch-exynos/system.h
@@ -42,6 +42,7 @@  struct exynos5_sysreg {
 	unsigned int	reserved;
 	unsigned int	ispblk_cfg;
 	unsigned int	usb20phy_cfg;
+	unsigned char	res2[0x29c];
 	unsigned int	mipi_dphy;
 	unsigned int	dptx_dphy;
 	unsigned int	phyclk_sel;