Message ID | 1337003909-2582-1-git-send-email-alban.crequy@collabora.co.uk |
---|---|
State | Rejected |
Headers | show |
On Monday 2012-05-14 15:58, Alban Crequy wrote: >--- a/include/linux/netfilter.h >+++ b/include/linux/netfilter.h >@@ -62,11 +62,11 @@ enum nf_inet_hooks { > > enum { > NFPROTO_UNSPEC = 0, >- NFPROTO_IPV4 = 2, >- NFPROTO_ARP = 3, >- NFPROTO_BRIDGE = 7, >- NFPROTO_IPV6 = 10, >- NFPROTO_DECNET = 12, >+ NFPROTO_IPV4, >+ NFPROTO_ARP, >+ NFPROTO_BRIDGE, >+ NFPROTO_IPV6, >+ NFPROTO_DECNET, > NFPROTO_NUMPROTO, > }; This must not be changed under any circumstances. It is exported to and used by userspace. (Except perhaps for NFPROTO_DECNET, which refers to a quite dead protocol that I think no user parts have ever used NFPROTO_DECNET.) I would consider it acceptable to change the value for NFPROTO_DECNET if Pablo joins. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le Mon, 14 May 2012 17:09:54 +0200 (CEST), Jan Engelhardt <jengelh@inai.de> a écrit : > > On Monday 2012-05-14 15:58, Alban Crequy wrote: > >--- a/include/linux/netfilter.h > >+++ b/include/linux/netfilter.h > >@@ -62,11 +62,11 @@ enum nf_inet_hooks { > > > > enum { > > NFPROTO_UNSPEC = 0, > >- NFPROTO_IPV4 = 2, > >- NFPROTO_ARP = 3, > >- NFPROTO_BRIDGE = 7, > >- NFPROTO_IPV6 = 10, > >- NFPROTO_DECNET = 12, > >+ NFPROTO_IPV4, > >+ NFPROTO_ARP, > >+ NFPROTO_BRIDGE, > >+ NFPROTO_IPV6, > >+ NFPROTO_DECNET, > > NFPROTO_NUMPROTO, > > }; > > This must not be changed under any circumstances. It is exported to > and used by userspace. (Except perhaps for NFPROTO_DECNET, which > refers to a quite dead protocol that I think no user parts have ever > used NFPROTO_DECNET.) I would consider it acceptable to change the > value for NFPROTO_DECNET if Pablo joins. Thanks for the review. I didn't realize it was exported to and used by userspace. I would drop this patch then. Alban -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 14, 2012 at 05:09:54PM +0200, Jan Engelhardt wrote: > > On Monday 2012-05-14 15:58, Alban Crequy wrote: > >--- a/include/linux/netfilter.h > >+++ b/include/linux/netfilter.h > >@@ -62,11 +62,11 @@ enum nf_inet_hooks { > > > > enum { > > NFPROTO_UNSPEC = 0, > >- NFPROTO_IPV4 = 2, > >- NFPROTO_ARP = 3, > >- NFPROTO_BRIDGE = 7, > >- NFPROTO_IPV6 = 10, > >- NFPROTO_DECNET = 12, > >+ NFPROTO_IPV4, > >+ NFPROTO_ARP, > >+ NFPROTO_BRIDGE, > >+ NFPROTO_IPV6, > >+ NFPROTO_DECNET, > > NFPROTO_NUMPROTO, > > }; > > This must not be changed under any circumstances. It is exported to > and used by userspace. (Except perhaps for NFPROTO_DECNET, which > refers to a quite dead protocol that I think no user parts have ever > used NFPROTO_DECNET.) I would consider it acceptable to change the > value for NFPROTO_DECNET if Pablo joins. If there is some remote posibility to break userspace code, I won't take the patch, sorry. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h index 29734be..89afadb 100644 --- a/include/linux/netfilter.h +++ b/include/linux/netfilter.h @@ -62,11 +62,11 @@ enum nf_inet_hooks { enum { NFPROTO_UNSPEC = 0, - NFPROTO_IPV4 = 2, - NFPROTO_ARP = 3, - NFPROTO_BRIDGE = 7, - NFPROTO_IPV6 = 10, - NFPROTO_DECNET = 12, + NFPROTO_IPV4, + NFPROTO_ARP, + NFPROTO_BRIDGE, + NFPROTO_IPV6, + NFPROTO_DECNET, NFPROTO_NUMPROTO, };