| Submitter | Wang Sheng-Hui |
|---|---|
| Date | May 14, 2012, 7:15 a.m. |
| Message ID | <4FB0B0F4.3060908@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/158889/ |
| State | Not Applicable |
| Headers | show |
Comments
On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote: > ext2_export_ops gets more valued fields, not get_parent only. > Clean up the comment. Um, I'd just remove the whole comment. It isn't particularly informative anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway... Honza > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > --- > fs/ext2/super.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index e1025c7..640b4c6 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, > /* Yes, most of these are left as NULL!! > * A NULL value implies the default, which works with ext2-like file > * systems, but can be improved upon. > - * Currently only get_parent is required. > */ > static const struct export_operations ext2_export_ops = { > .fh_to_dentry = ext2_fh_to_dentry, > -- > 1.7.1
Patch
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index e1025c7..640b4c6 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, /* Yes, most of these are left as NULL!! * A NULL value implies the default, which works with ext2-like file * systems, but can be improved upon. - * Currently only get_parent is required. */ static const struct export_operations ext2_export_ops = { .fh_to_dentry = ext2_fh_to_dentry,
ext2_export_ops gets more valued fields, not get_parent only. Clean up the comment. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- fs/ext2/super.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)