Patchwork [U-Boot,5/8] m28evk: fix board config include guardian macro name

login
register
mail settings
Submitter Otavio Salvador
Date May 12, 2012, 11:40 p.m.
Message ID <1336866018-614-6-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/158797/
State Accepted
Commit 212033fc9a6bb10e97712e309fc53c9316acdaa8
Delegated to: Stefano Babic
Headers show

Comments

Otavio Salvador - May 12, 2012, 11:40 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 include/configs/m28evk.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Marek Vasut - May 13, 2012, 5:12 p.m.
Dear Otavio Salvador,

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  include/configs/m28evk.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> index ebf7e39..c1ae996 100644
> --- a/include/configs/m28evk.h
> +++ b/include/configs/m28evk.h
> @@ -17,8 +17,8 @@
>   * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>   * MA 02111-1307 USA
>   */
> -#ifndef __M28_H__
> -#define __M28_H__
> +#ifndef __M28EVK_CONFIG_H__
> +#define __M28EVK_CONFIG_H__

The module itself is called "m28", but this change is ok with me. WD?

> 
>  #include <asm/arch/regs-base.h>
> 
> @@ -327,4 +327,4 @@
>  		"fi ; "							\
>  		"fi\0"
> 
> -#endif /* __M28_H__ */
> +#endif /* __M28EVK_CONFIG_H__ */

Best regards,
Marek Vasut
Wolfgang Denk - May 13, 2012, 6:46 p.m.
Dear Marek Vasut,

In message <201205131912.57149.marex@denx.de> you wrote:
> Dear Otavio Salvador,
> 
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > ---
> >  include/configs/m28evk.h |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> > index ebf7e39..c1ae996 100644
> > --- a/include/configs/m28evk.h
> > +++ b/include/configs/m28evk.h
> > @@ -17,8 +17,8 @@
> >   * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> >   * MA 02111-1307 USA
> >   */
> > -#ifndef __M28_H__
> > -#define __M28_H__
> > +#ifndef __M28EVK_CONFIG_H__
> > +#define __M28EVK_CONFIG_H__
> 
> The module itself is called "m28", but this change is ok with me. WD?

It's OK with me, too.

Best regards,

Wolfgang Denk
Marek Vasut - May 13, 2012, 6:53 p.m.
Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <201205131912.57149.marex@denx.de> you wrote:
> > Dear Otavio Salvador,
> > 
> > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > ---
> > > 
> > >  include/configs/m28evk.h |    6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> > > index ebf7e39..c1ae996 100644
> > > --- a/include/configs/m28evk.h
> > > +++ b/include/configs/m28evk.h
> > > @@ -17,8 +17,8 @@
> > > 
> > >   * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > >   * MA 02111-1307 USA
> > >   */
> > > 
> > > -#ifndef __M28_H__
> > > -#define __M28_H__
> > > +#ifndef __M28EVK_CONFIG_H__
> > > +#define __M28EVK_CONFIG_H__
> > 
> > The module itself is called "m28", but this change is ok with me. WD?
> 
> It's OK with me, too.

Acked-by: Marek Vasut <marex@denx.de>

> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut
Stefano Babic - June 13, 2012, 9:07 a.m.
On 13/05/2012 01:40, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  include/configs/m28evk.h |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> index ebf7e39..c1ae996 100644

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index ebf7e39..c1ae996 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -17,8 +17,8 @@ 
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
  * MA 02111-1307 USA
  */
-#ifndef __M28_H__
-#define __M28_H__
+#ifndef __M28EVK_CONFIG_H__
+#define __M28EVK_CONFIG_H__
 
 #include <asm/arch/regs-base.h>
 
@@ -327,4 +327,4 @@ 
 		"fi ; "							\
 		"fi\0"
 
-#endif /* __M28_H__ */
+#endif /* __M28EVK_CONFIG_H__ */