Patchwork ext4: fix the code style from printk to ext_debug in extents.c

login
register
mail settings
Submitter Steven Liu
Date May 12, 2012, 3:57 p.m.
Message ID <CADxeRwnv7quZbWn9xZ=KnEg_KyT65DApEt57zDdgeYsRgQKYQw@mail.gmail.com>
Download mbox | patch
Permalink /patch/158755/
State Rejected
Headers show

Comments

Steven Liu - May 12, 2012, 3:57 p.m.
Hi Ted,

just fix the printk debug to ext_debug, if undefined the EXT_DEBUG
it will not output the debug message

Signed-off-by: LiuQi <liuqi@zecloud.cn>
---
 fs/ext4/extents.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--
1.7.1



Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - May 13, 2012, 4:20 a.m.
On Sat, May 12, 2012 at 11:57:13PM +0800, Steven Liu wrote:
> Hi Ted,
> 
> just fix the printk debug to ext_debug, if undefined the EXT_DEBUG
> it will not output the debug message
> 
> Signed-off-by: LiuQi <liuqi@zecloud.cn>

I'm not sure what's the point?  The code in question is all under a
CHECK_BINSEARCH, which is in itself a debugging option.

		       	     	      		- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steven Liu - May 13, 2012, 2:38 p.m.
Hi ,
  You mean ,if open the CHECK_BINSEARCH, it must output the message
which I have changed code?

Thanks

2012/5/13 Ted Ts'o <tytso@mit.edu>:
> On Sat, May 12, 2012 at 11:57:13PM +0800, Steven Liu wrote:
>> Hi Ted,
>>
>> just fix the printk debug to ext_debug, if undefined the EXT_DEBUG
>> it will not output the debug message
>>
>> Signed-off-by: LiuQi <liuqi@zecloud.cn>
>
> I'm not sure what's the point?  The code in question is all under a
> CHECK_BINSEARCH, which is in itself a debugging option.
>
>                                                - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index abcdeab..211e230 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -548,10 +548,10 @@  ext4_ext_binsearch_idx(struct inode *inode,
        for (k = 0; k < le16_to_cpu(eh->eh_entries); k++, ix++) {
          if (k != 0 &&
              le32_to_cpu(ix->ei_block) <= le32_to_cpu(ix[-1].ei_block)) {
-               printk(KERN_DEBUG "k=%d, ix=0x%p, "
+               ext_debug("k=%d, ix=0x%p, "
                       "first=0x%p\n", k,
                       ix, EXT_FIRST_INDEX(eh));
-               printk(KERN_DEBUG "%u <= %u\n",
+               ext_debug("%u <= %u\n",
                       le32_to_cpu(ix->ei_block),
                       le32_to_cpu(ix[-1].ei_block));
            }