From patchwork Sat May 12 06:51:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 158692 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4A42CB7028 for ; Sat, 12 May 2012 16:52:06 +1000 (EST) Received: from localhost ([::1]:34084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ST6BQ-0007JC-8b for incoming@patchwork.ozlabs.org; Sat, 12 May 2012 02:52:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ST6BJ-0007Iu-Ku for qemu-devel@nongnu.org; Sat, 12 May 2012 02:51:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ST6BH-0005Zz-Rw for qemu-devel@nongnu.org; Sat, 12 May 2012 02:51:57 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:42476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ST6BH-0005Zq-LQ for qemu-devel@nongnu.org; Sat, 12 May 2012 02:51:55 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 0200F7280017; Sat, 12 May 2012 08:51:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5NrhEnhS-vel; Sat, 12 May 2012 08:51:53 +0200 (CEST) Received: by v220110690675601.yourvserver.net (Postfix, from userid 1000) id 6152E7280018; Sat, 12 May 2012 08:51:53 +0200 (CEST) From: Stefan Weil To: qemu-devel@nongnu.org Date: Sat, 12 May 2012 08:51:52 +0200 Message-Id: <1336805512-18492-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.9 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 78.47.199.172 Cc: Paolo Bonzini , Anthony Liguori , Stefan Weil Subject: [Qemu-devel] [PATCH 1.1] qemu-timer: Fix wrong error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Function timeSetEvent returns 0 when it fails, but it does not set an error code which can be retrieved by GetLastError. Therefore calling GetLastError is useless. Signed-off-by: Stefan Weil --- qemu-timer.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 4a6fc98..de98977 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -635,8 +635,7 @@ static int mm_start_timer(struct qemu_alarm_timer *t) TIME_ONESHOT | TIME_CALLBACK_FUNCTION); if (!mm_timer) { - fprintf(stderr, "Failed to initialize win32 alarm timer: %ld\n", - GetLastError()); + fprintf(stderr, "Failed to initialize win32 alarm timer\n"); timeEndPeriod(mm_tc.wPeriodMin); return -1; } @@ -667,9 +666,7 @@ static void mm_rearm_timer(struct qemu_alarm_timer *t, int64_t delta) TIME_ONESHOT | TIME_CALLBACK_FUNCTION); if (!mm_timer) { - fprintf(stderr, "Failed to re-arm win32 alarm timer %ld\n", - GetLastError()); - + fprintf(stderr, "Failed to re-arm win32 alarm timer\n"); timeEndPeriod(mm_tc.wPeriodMin); exit(1); }