Patchwork [U-Boot] mx53: Fix mask for SATA reference clock

login
register
mail settings
Submitter Fabio Estevam
Date May 12, 2012, 12:39 a.m.
Message ID <1336783151-7567-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/158655/
State Accepted
Commit 3f5f200bbe9aee283b88a2647763b1f97abb96ac
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - May 12, 2012, 12:39 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

SATA_ALT_REF_CLK field corresponds to bits 1 and 2 of offset 0x180c.

Fix the mask for these bits.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Stefano,

I don't have a SATA disk handy to try this.

 arch/arm/cpu/armv7/mx5/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Fabio Estevam - May 29, 2012, 9:40 p.m.
On Fri, May 11, 2012 at 9:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> SATA_ALT_REF_CLK field corresponds to bits 1 and 2 of offset 0x180c.

Just in case someone would like to check the mx53 fuse map, it is now
available at:
http://cache.freescale.com/files/dsp/doc/ref_manual/IMX53RMAD.pdf?fpsp=1&WT_TYPE=Reference%20Manuals&WT_VENDOR=FREESCALE&WT_FILE_FORMAT=pdf&WT_ASSET=Documentation

Regards,

Fabio Estevam
Stefano Babic - June 12, 2012, 5:23 p.m.
On 29/05/2012 23:40, Fabio Estevam wrote:
> On Fri, May 11, 2012 at 9:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> SATA_ALT_REF_CLK field corresponds to bits 1 and 2 of offset 0x180c.
> 
> Just in case someone would like to check the mx53 fuse map, it is now
> available at:
> http://cache.freescale.com/files/dsp/doc/ref_manual/IMX53RMAD.pdf?fpsp=1&WT_TYPE=Reference%20Manuals&WT_VENDOR=FREESCALE&WT_FILE_FORMAT=pdf&WT_ASSET=Documentation
> 

Thanks, Fabio !

Regards,
Stefano
Stefano Babic - June 12, 2012, 5:24 p.m.
On 12/05/2012 02:39, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> SATA_ALT_REF_CLK field corresponds to bits 1 and 2 of offset 0x180c.
> 
> Fix the mask for these bits.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/arch/arm/cpu/armv7/mx5/clock.c b/arch/arm/cpu/armv7/mx5/clock.c
index fc2406b..64862b3 100644
--- a/arch/arm/cpu/armv7/mx5/clock.c
+++ b/arch/arm/cpu/armv7/mx5/clock.c
@@ -843,7 +843,7 @@  void mxc_set_sata_internal_clock(void)
 
 	set_usb_phy1_clk();
 
-	writel((readl(tmp_base) & (~0x7)) | 0x4, tmp_base);
+	writel((readl(tmp_base) & (~0x6)) | 0x4, tmp_base);
 }
 #endif