From patchwork Fri May 11 20:30:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 158590 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 191EEB700D for ; Sat, 12 May 2012 06:32:20 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SSwUQ-000516-BK; Fri, 11 May 2012 20:31:02 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SSwUE-000504-4d for linux-mtd@lists.infradead.org; Fri, 11 May 2012 20:30:50 +0000 Received: by pbbrq13 with SMTP id rq13so4237804pbb.36 for ; Fri, 11 May 2012 13:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=z4nsMtLszIhcZVVUHNKdUfGQg3/yTRP4bU6XJ51VnRo=; b=YWbPPorZuxLCPRzfFKwLSXFwMoNj0MevRHVM9lDbLfLgXjUItIyyDRBZW3kcY03Ksy CI8WVjGK3GiGoT9WjpBc5HpVbYRID4nvUR70siP/0HgRvMUB8zAn1w1DQ/f9ck1bjdEr cnhPlPuEqXQIh+H9cTRDtIOpPzPNgHTkoyEmYiCHE+T+UXwSk2saNeNwljCd05P6dkqm nkXdaiRuFH3+wia0NkHxDL2lCgjGaLU9YciqJa7PaAsKwDr/fz9ItWHcLzIDDGxhIg5H FshtiZvtPvQtqR7UF9xPcjvcpdEgkuL2nqNNXbysscvmtjbwrvWhmh0T/hISoSDG35V5 9C0A== Received: by 10.68.191.230 with SMTP id hb6mr16126053pbc.57.1336768248672; Fri, 11 May 2012 13:30:48 -0700 (PDT) Received: from localhost.localdomain (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPS id va3sm9442063pbc.9.2012.05.11.13.30.47 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 May 2012 13:30:48 -0700 (PDT) From: Brian Norris To: Artem Bityutskiy Subject: [PATCH 3/3] mtd: nand: gpmi: [FIXME] need to use {read, write}_oob_raw Date: Fri, 11 May 2012 13:30:35 -0700 Message-Id: <1336768235-12658-3-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 1.7.5.4.2.g519b1 In-Reply-To: <1336768235-12658-1-git-send-email-computersforpeace@gmail.com> References: <1336768235-12658-1-git-send-email-computersforpeace@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Huang Shijie , Brian Norris , linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch is simply an added warning in the comments. Ideally, this patch need not be merged, but rather, a developer will write a proper solution that can use the ecc.read_oob_raw and ecc.write_oob_raw interfaces. Signed-off-by: Brian Norris Cc: Huang Shijie --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 8250f63..033bd7a 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -1054,6 +1054,9 @@ exit_auxiliary: * ECC-based or raw view of the page is implicit in which function it calls * (there is a similar pair of ECC-based/raw functions for writing). * + * FIXME: The following paragraph is incorrect, now that there exist + * ecc.read_oob_raw and ecc.write_oob_raw functions. + * * Since MTD assumes the OOB is not covered by ECC, there is no pair of * ECC-based/raw functions for reading or or writing the OOB. The fact that the * caller wants an ECC-based or raw view of the page is not propagated down to