From patchwork Fri May 11 17:51:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Maluka X-Patchwork-Id: 158562 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3656BB7021 for ; Sat, 12 May 2012 03:50:52 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SStxy-0000ir-Nx; Fri, 11 May 2012 17:49:22 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SStxv-0000il-Mk for linux-mtd@merlin.infradead.org; Fri, 11 May 2012 17:49:20 +0000 Received: from mail.adb.com.ua ([193.105.30.103]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SStxt-000530-IX for linux-mtd@lists.infradead.org; Fri, 11 May 2012 17:49:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.adb.com.ua (Postfix) with ESMTP id A064F387260 for ; Fri, 11 May 2012 20:42:53 +0300 (EEST) X-Virus-Scanned: amavisd-new at mail.adb.com.ua Received: from mail.adb.com.ua ([127.0.0.1]) by localhost (mail.adb.com.ua [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JXSuF9sa14m9 for ; Fri, 11 May 2012 20:42:53 +0300 (EEST) Received: from [192.168.23.7] (dmaluka.adb.ua [192.168.23.7]) by mail.adb.com.ua (Postfix) with ESMTPS id 28FD538725F for ; Fri, 11 May 2012 20:42:53 +0300 (EEST) Message-ID: <4FAD51B7.6010303@adbglobal.com> Date: Fri, 11 May 2012 20:51:51 +0300 From: Dmitry Maluka User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 MIME-Version: 1.0 To: linux-mtd@lists.infradead.org Subject: Missing offset increment in scan_read_raw_oob() X-Enigmail-Version: 1.4.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20120511_184917_771185_8A6E1CCD X-CRM114-Status: UNSURE ( 3.97 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org It seems there is a bug in scan_read_raw_oob() in nand_bbt.c which should cause wrong functioning of NAND_BBT_SCANALLPAGES option. Possible fix (relies on offs passed page-aligned): } Signed-off-by: Dmitry Maluka --- a/drivers/mtd/nand/nand_bbt.c +++ b/drivers/mtd/nand/nand_bbt.c @@ -324,6 +324,7 @@ static int scan_read_raw_oob(struct mtd_info *mtd, uint8_t *buf, loff_t offs, buf += mtd->oobsize + mtd->writesize; len -= mtd->writesize; + offs += mtd->writesize; } return 0;