From patchwork Thu May 10 14:23:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init Date: Thu, 10 May 2012 04:23:56 -0000 From: Kevin Hilman X-Patchwork-Id: 158327 Message-Id: <87mx5gm7wj.fsf@ti.com> To: Grant Likely Cc: "DebBarma, Tarun Kanti" , linux-omap@vger.kernel.org, Grazvydas Ignotas , linux-arm-kernel@lists.infradead.org, Janusz Krzysztofik Grant, "DebBarma, Tarun Kanti" writes: > Hi, > > On Thu, May 10, 2012 at 3:06 AM, Janusz Krzysztofik > wrote: >> On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote: >>> On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas wrote: >>> > On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma >>> > wrote: >>> >> Initialization of irqenable, irqstatus registers is the common >>> >> operation done in this function for all OMAP platforms, viz. OMAP1, >>> >> OMAP2+. The latter _gpio_rmw()'s which supposedly got introduced >>> >> wrongly to take care of OMAP2+ platforms were overwriting initially >>> >> programmed OMAP1 value breaking functionality on OMAP1. >> >> Hi, >> I can confirm that my other issues with GPIO on Amstrad Delta were not >> related, and this patch is still required for GPIO interrupts hardware >> being correctly initialized on OMAP1 in 3.4-rc6. You can add my >> >> Tested-by: Janusz Krzysztofik >> >> if you wish. > Thank you for confirming!! We'd like to get this one in for v3.4-rc. Can you queue it? I added the tested-by from Janusz and my signoff, and pull request is below. Thanks, Kevin The following changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3: Linux 3.4-rc6 (2012-05-06 15:07:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/fixes/gpio for you to fetch changes up to 6edd94db250038c8fdf176f23ca4017d2f312509: gpio/omap: fix incorrect initialization of omap_gpio_mod_init (2012-05-10 07:16:15 -0700) ---------------------------------------------------------------- Tarun Kanti DebBarma (1): gpio/omap: fix incorrect initialization of omap_gpio_mod_init drivers/gpio/gpio-omap.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)