From patchwork Thu Sep 25 21:37:14 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francois Romieu X-Patchwork-Id: 1581 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CB92FDE0F1 for ; Fri, 26 Sep 2008 07:37:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbYIYVhT (ORCPT ); Thu, 25 Sep 2008 17:37:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754091AbYIYVhT (ORCPT ); Thu, 25 Sep 2008 17:37:19 -0400 Received: from electric-eye.fr.zoreil.com ([213.41.134.224]:33639 "EHLO electric-eye.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051AbYIYVhS (ORCPT ); Thu, 25 Sep 2008 17:37:18 -0400 Received: from electric-eye.fr.zoreil.com (localhost.localdomain [127.0.0.1]) by electric-eye.fr.zoreil.com (8.14.1/8.14.1) with ESMTP id m8PLbEvO020782; Thu, 25 Sep 2008 23:37:14 +0200 Received: (from romieu@localhost) by electric-eye.fr.zoreil.com (8.14.1/8.14.1/Submit) id m8PLbEUj020781; Thu, 25 Sep 2008 23:37:14 +0200 Date: Thu, 25 Sep 2008 23:37:14 +0200 From: Francois Romieu To: Meelis Roos Cc: netdev@vger.kernel.org Subject: Re: via-velocity warnings on sparc64 Message-ID: <20080925213714.GA13178@electric-eye.fr.zoreil.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Meelis Roos : > Noticed this while compiling 2.6.27-rc7+git on sparc64 - maybe it is of > interest. > > CC [M] drivers/net/via-velocity.o > drivers/net/via-velocity.c: In function 'velocity_free_rd_ring': > drivers/net/via-velocity.c:1275: warning: cast from pointer to integer of different size > drivers/net/via-velocity.c: In function 'velocity_free_td_ring_entry': > drivers/net/via-velocity.c:1336: warning: cast from pointer to integer of different size Something like the patch below maybe ? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c index 007c129..ad20f96 100644 --- a/drivers/net/via-velocity.c +++ b/drivers/net/via-velocity.c @@ -1272,7 +1272,7 @@ static void velocity_free_rd_ring(struct velocity_info *vptr) continue; pci_unmap_single(vptr->pdev, rd_info->skb_dma, vptr->rx.buf_sz, PCI_DMA_FROMDEVICE); - rd_info->skb_dma = (dma_addr_t) NULL; + rd_info->skb_dma = 0; dev_kfree_skb(rd_info->skb); rd_info->skb = NULL; @@ -1333,7 +1333,7 @@ static void velocity_free_td_ring_entry(struct velocity_info *vptr, if (td_info->skb_dma[i]) { pci_unmap_single(vptr->pdev, td_info->skb_dma[i], td_info->skb->len, PCI_DMA_TODEVICE); - td_info->skb_dma[i] = (dma_addr_t) NULL; + td_info->skb_dma[i] = 0; } } dev_kfree_skb(td_info->skb);