Patchwork [V3,1/3] ata: pata_arasan: Add clk_{un}prepare() support

login
register
mail settings
Submitter Viresh KUMAR
Date May 9, 2012, 4:08 a.m.
Message ID <9848a1a6838c4f3a7e0cbd6cdc3bc6146fd2e2cc.1336536285.git.viresh.kumar@st.com>
Download mbox | patch
Permalink /patch/157849/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Viresh KUMAR - May 9, 2012, 4:08 a.m.
clk_{un}prepare is mandatory for platforms using common clock framework. Since
this driver is used by SPEAr platform, which supports common clock framework,
add clk_{un}prepare() support for it.

Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
 drivers/ata/pata_arasan_cf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Jeff Garzik - May 22, 2012, 8:01 p.m.
On 05/09/2012 12:08 AM, Viresh Kumar wrote:
> clk_{un}prepare is mandatory for platforms using common clock framework. Since
> this driver is used by SPEAr platform, which supports common clock framework,
> add clk_{un}prepare() support for it.
>
> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
> ---
>   drivers/ata/pata_arasan_cf.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)



these do not apply to upstream, for me...

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
viresh kumar - June 13, 2012, 9:12 a.m.
Hi Jeff,

On Tue, May 22, 2012 at 9:01 PM, Jeff Garzik <jeff@garzik.org> wrote:
> On 05/09/2012 12:08 AM, Viresh Kumar wrote:
>>
>> clk_{un}prepare is mandatory for platforms using common clock framework.
>> Since
>> this driver is used by SPEAr platform, which supports common clock
>> framework,
>> add clk_{un}prepare() support for it.
>>
>> Signed-off-by: Viresh Kumar<viresh.kumar@st.com>
>> ---
>>  drivers/ata/pata_arasan_cf.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>
>
>
>
> these do not apply to upstream, for me...
>

Sorry for being late. I rebased them on linux-next that time as they
had few dependency commits there.
Can you try it there?

--
Viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
viresh kumar - July 16, 2012, 11:37 a.m.
On Wed, Jun 13, 2012 at 10:12 AM, viresh kumar <viresh.linux@gmail.com> wrote:
>> these do not apply to upstream, for me...
>>
>
> Sorry for being late. I rebased them on linux-next that time as they
> had few dependency commits there.
> Can you try it there?

Ping !!

Can you please retry applying them?
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index b943be0..febc914 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -310,7 +310,7 @@  static int cf_init(struct arasan_cf_dev *acdev)
 	unsigned long flags;
 	int ret = 0;
 
-	ret = clk_enable(acdev->clk);
+	ret = clk_prepare_enable(acdev->clk);
 	if (ret) {
 		dev_dbg(acdev->host->dev, "clock enable failed");
 		return ret;
@@ -340,7 +340,7 @@  static void cf_exit(struct arasan_cf_dev *acdev)
 	writel(readl(acdev->vbase + OP_MODE) & ~CFHOST_ENB,
 			acdev->vbase + OP_MODE);
 	spin_unlock_irqrestore(&acdev->host->lock, flags);
-	clk_disable(acdev->clk);
+	clk_disable_unprepare(acdev->clk);
 }
 
 static void dma_callback(void *dev)