Patchwork Added package v86d which provides a real-mode helper for uvesafb driver.

login
register
mail settings
Submitter Dimitry Golubovsky
Date May 9, 2012, 1:19 a.m.
Message ID <1336526367-11516-1-git-send-email-golubovsky@gmail.com>
Download mbox | patch
Permalink /patch/157844/
State Superseded
Headers show

Comments

Dimitry Golubovsky - May 9, 2012, 1:19 a.m.
Signed-off-by: Dmitry <golubovsky@gmail.com>
---
 package/Config.in      |    1 +
 package/v86d/Config.in |    9 +++++++++
 package/v86d/v86d.mk   |   36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 package/v86d/Config.in
 create mode 100644 package/v86d/v86d.mk
Baruch Siach - May 9, 2012, 3:45 a.m.
Hi Dmitry,

Two more comments.

On Tue, May 08, 2012 at 09:19:27PM -0400, Dmitry wrote:
> Signed-off-by: Dmitry <golubovsky@gmail.com>
> ---
>  package/Config.in      |    1 +
>  package/v86d/Config.in |    9 +++++++++
>  package/v86d/v86d.mk   |   36 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 46 insertions(+), 0 deletions(-)
>  create mode 100644 package/v86d/Config.in
>  create mode 100644 package/v86d/v86d.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 34c0280..208e66f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -230,6 +230,7 @@ source "package/unionfs/Config.in"
>  source "package/usb_modeswitch/Config.in"
>  source "package/usbmount/Config.in"
>  source "package/usbutils/Config.in"
> +source "package/v86d/Config.in"
>  source "package/wipe/Config.in"
>  source "package/xfsprogs/Config.in"
>  endmenu
> diff --git a/package/v86d/Config.in b/package/v86d/Config.in
> new file mode 100644
> index 0000000..ba1baca
> --- /dev/null
> +++ b/package/v86d/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_V86D
> +	bool "v86d"
> +	depends on (BR2_i386 || BR2_x86_64)
> +	help
> +	  v86d is the userspace helper that runs x86 code in an emulated
> +	  environment. uvesafb will not work without v86d. v86d currently
> +	  supports the x86 and amd64 (x86-64) architectures.
> +
> +	  http://dev.gentoo.org/~spock/projects/uvesafb/
> diff --git a/package/v86d/v86d.mk b/package/v86d/v86d.mk
> new file mode 100644
> index 0000000..a0d3ed2
> --- /dev/null
> +++ b/package/v86d/v86d.mk
> @@ -0,0 +1,36 @@
> +############################################
> +#
> +# v86d
> +# 
> +############################################
> +
> +V86D_VERSION = 0.1.10
> +V86D_SOURCE = v86d-$(V86D_VERSION).tar.bz2
> +V86D_SITE = http://dev.gentoo.org/~spock/projects/uvesafb/archive
> +
> +# This flag to configure should be per target architecture rather than
> +# autodetected (or it will be per host architecture which may be 
> +# not the same as target).
> +
> +ifeq ($(BR2_i386),y)
> +	x86emu = n
> +endif
> +
> +ifeq ($(BR2_x86_64),y)
> +	x86emu = y
> +endif

We generally use capitals for variable names. Also, this can be shortened to

    X86EMU = $(if $(BR2_i386),n,y)

> +
> +# v86d's configure script is not autoconf-based.
> +# GENTARGETS macro will be used rather than AUTOTARGETS.
> +
> +define V86D_CONFIGURE_CMDS
> +	(cd $(@D) ; ./configure --with-debug=n --with-klibc=n --with-x86emu=$(x86emu))
> +endef
> +
> +# It is necessary to define __i386__ explicitly in CFLAGS for successful compilation.

But you don't used the CFLAGS variable. Please correct the comment.

Thanks for your persistence.

baruch

> +
> +define V86D_BUILD_CMDS
> +	$(MAKE) CC="$(TARGET_CC) -D__i386__" LD="$(TARGET_LD)" -C $(@D) all
> +endef
> +
> +$(eval $(call GENTARGETS))
Dimitry Golubovsky - May 9, 2012, 3:47 a.m.
Baruch,

On Tue, May 8, 2012 at 11:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Dmitry,
>
> Two more comments.
>> +
>> +ifeq ($(BR2_i386),y)
>> +     x86emu = n
>> +endif
>> +
>> +ifeq ($(BR2_x86_64),y)
>> +     x86emu = y
>> +endif
>
> We generally use capitals for variable names. Also, this can be shortened to
>
>    X86EMU = $(if $(BR2_i386),n,y)

This is a local variable - still uppercase?

>
> But you don't used the CFLAGS variable. Please correct the comment.

Right, I'll correct this.

Thanks.
Baruch Siach - May 9, 2012, 4:32 a.m.
Hi Dmitry,

On Tue, May 08, 2012 at 11:47:57PM -0400, Dmitry Golubovsky wrote:
> Baruch,
> 
> On Tue, May 8, 2012 at 11:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > Hi Dmitry,
> >
> > Two more comments.
> >> +
> >> +ifeq ($(BR2_i386),y)
> >> +     x86emu = n
> >> +endif
> >> +
> >> +ifeq ($(BR2_x86_64),y)
> >> +     x86emu = y
> >> +endif
> >
> > We generally use capitals for variable names. Also, this can be shortened to
> >
> >    X86EMU = $(if $(BR2_i386),n,y)
> 
> This is a local variable - still uppercase?

Yes.

baruch

> > But you don't used the CFLAGS variable. Please correct the comment.
> 
> Right, I'll correct this.
> 
> Thanks.
> 
> -- 
> Dmitry Golubovsky

Patch

diff --git a/package/Config.in b/package/Config.in
index 34c0280..208e66f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -230,6 +230,7 @@  source "package/unionfs/Config.in"
 source "package/usb_modeswitch/Config.in"
 source "package/usbmount/Config.in"
 source "package/usbutils/Config.in"
+source "package/v86d/Config.in"
 source "package/wipe/Config.in"
 source "package/xfsprogs/Config.in"
 endmenu
diff --git a/package/v86d/Config.in b/package/v86d/Config.in
new file mode 100644
index 0000000..ba1baca
--- /dev/null
+++ b/package/v86d/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_V86D
+	bool "v86d"
+	depends on (BR2_i386 || BR2_x86_64)
+	help
+	  v86d is the userspace helper that runs x86 code in an emulated
+	  environment. uvesafb will not work without v86d. v86d currently
+	  supports the x86 and amd64 (x86-64) architectures.
+
+	  http://dev.gentoo.org/~spock/projects/uvesafb/
diff --git a/package/v86d/v86d.mk b/package/v86d/v86d.mk
new file mode 100644
index 0000000..a0d3ed2
--- /dev/null
+++ b/package/v86d/v86d.mk
@@ -0,0 +1,36 @@ 
+############################################
+#
+# v86d
+# 
+############################################
+
+V86D_VERSION = 0.1.10
+V86D_SOURCE = v86d-$(V86D_VERSION).tar.bz2
+V86D_SITE = http://dev.gentoo.org/~spock/projects/uvesafb/archive
+
+# This flag to configure should be per target architecture rather than
+# autodetected (or it will be per host architecture which may be 
+# not the same as target).
+
+ifeq ($(BR2_i386),y)
+	x86emu = n
+endif
+
+ifeq ($(BR2_x86_64),y)
+	x86emu = y
+endif
+
+# v86d's configure script is not autoconf-based.
+# GENTARGETS macro will be used rather than AUTOTARGETS.
+
+define V86D_CONFIGURE_CMDS
+	(cd $(@D) ; ./configure --with-debug=n --with-klibc=n --with-x86emu=$(x86emu))
+endef
+
+# It is necessary to define __i386__ explicitly in CFLAGS for successful compilation.
+
+define V86D_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC) -D__i386__" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+$(eval $(call GENTARGETS))