Patchwork ata, Add " 2GB ATA Flash Disk"/"ADMA428M" to DMA blacklist

login
register
mail settings
Submitter Prarit Bhargava
Date May 8, 2012, 1:08 p.m.
Message ID <1336482482-3200-1-git-send-email-prarit@redhat.com>
Download mbox | patch
Permalink /patch/157678/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Prarit Bhargava - May 8, 2012, 1:08 p.m.
A user has several systems with a couple of models of flash disks with IDE
connectors.  These disks work fine in 2.6.18-ish kernels but corrupt data on
new kernels.

The difference appears to be with the default I/O method used by the IDE
controller driver between the kernels.  In the older kernels, the
configuration is very conservative and the driver stays in PIO mode.  With
new kernels, the ata driver (pata_serverworks) attempts to use UDMA/66
which the drive claims to support.  This mode, however, does not appear to
work in DMA mode.  The drive does work correctly and no corruption is
seen if the kernel parameter "libata.force=5:pio0,6:pio0" is used to force
the driver to use PIO instead of DMA mode.

Blacklist these drives.  Unfortunately the model name of the drive is very
generic, " 2GB ATA Flash Disk", but the revision is specific, "ADMA428M".

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Jeff Garzik <jgarzik@pobox.com>
---
 drivers/ata/libata-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Jeff Garzik - May 22, 2012, 8:04 p.m.
On 05/08/2012 09:08 AM, Prarit Bhargava wrote:
> A user has several systems with a couple of models of flash disks with IDE
> connectors.  These disks work fine in 2.6.18-ish kernels but corrupt data on
> new kernels.
>
> The difference appears to be with the default I/O method used by the IDE
> controller driver between the kernels.  In the older kernels, the
> configuration is very conservative and the driver stays in PIO mode.  With
> new kernels, the ata driver (pata_serverworks) attempts to use UDMA/66
> which the drive claims to support.  This mode, however, does not appear to
> work in DMA mode.  The drive does work correctly and no corruption is
> seen if the kernel parameter "libata.force=5:pio0,6:pio0" is used to force
> the driver to use PIO instead of DMA mode.
>
> Blacklist these drives.  Unfortunately the model name of the drive is very
> generic, " 2GB ATA Flash Disk", but the revision is specific, "ADMA428M".
>
> Signed-off-by: Prarit Bhargava<prarit@redhat.com>
> Cc: Jeff Garzik<jgarzik@pobox.com>
> ---
>   drivers/ata/libata-core.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)

applied



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 23763a1..0213a39 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4051,6 +4051,7 @@  static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "_NEC DV5800A", 	NULL,		ATA_HORKAGE_NODMA },
 	{ "SAMSUNG CD-ROM SN-124", "N001",	ATA_HORKAGE_NODMA },
 	{ "Seagate STT20000A", NULL,		ATA_HORKAGE_NODMA },
+	{ "2GB ATA Flash Disk", "ADMA428M",	ATA_HORKAGE_NODMA },
 	/* Odd clown on sil3726/4726 PMPs */
 	{ "Config  Disk",	NULL,		ATA_HORKAGE_DISABLE },