From patchwork Tue May 8 03:24:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Liu X-Patchwork-Id: 157549 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EB2B4B6FA5 for ; Tue, 8 May 2012 13:17:18 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902Ab2EHDRR (ORCPT ); Mon, 7 May 2012 23:17:17 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:59643 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846Ab2EHDRQ (ORCPT ); Mon, 7 May 2012 23:17:16 -0400 Received: by dady13 with SMTP id y13so2070352dad.19 for ; Mon, 07 May 2012 20:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=SejORz7aoiRoKVP7IcoE/wQzltqPHM0YLxYQTaPy1o0=; b=WKy68pyDjQv+XpMvriaMyak3jZZza1d6DSsYkcOiTb2W1IDwPmDU0YfkRmzDGT2pd8 Fx1WoKXf7Gr10H/mcmTfSQYOf7S2IPyJpJ196rkQbnq6AL7I/ePoi4uioBo+jsAbXsi8 H7wKo99oGWurkP77LkIpkL3cKRek7/AiZRM2ETOw8UwIR/4iGa7wCOoer1Ng9eVgZZuM 43VrqKpBiVAY8A0PLcdztE19uPQ9Odl7nudU/imCOjbAhYa4aOH1ZYOIk6sHT2DJibUU ZpC5Jukv+dMJ/HwBVT5aqwMXoL2GHZUnWbxNYpk9hm9Hso5bXENGrRbdR/kxCXRAomnl bL7g== Received: by 10.68.202.8 with SMTP id ke8mr17596628pbc.94.1336447036039; Mon, 07 May 2012 20:17:16 -0700 (PDT) Received: from localhost.localdomain ([182.92.247.2]) by mx.google.com with ESMTPS id d4sm823974pbr.32.2012.05.07.20.17.10 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 May 2012 20:17:15 -0700 (PDT) From: Zheng Liu To: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org Cc: Jeff Garzik , Zheng Liu Subject: [RFC][PATCH] libata: enable SATA disk fua detection on default Date: Tue, 8 May 2012 11:24:03 +0800 Message-Id: <1336447443-4685-1-git-send-email-wenqing.lz@taobao.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Zheng Liu Currently, SATA disk fua detection is disabled on default because most of devices don't support this feature at that time. With the development of technology, more and more SATA disks support this feature. So now we can enable this detection on default. Although fua detection is defined as a kernel module parameter, it is too hard to set its value because it must be loaded and set before system starts up. That needs to modify initrd file. So it is inconvenient for administrator who needs to manage a huge number of servers. CC: Jeff Garzik Signed-off-by: Zheng Liu --- drivers/ata/libata-core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 23763a1..3627251 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -133,9 +133,9 @@ int atapi_passthru16 = 1; module_param(atapi_passthru16, int, 0444); MODULE_PARM_DESC(atapi_passthru16, "Enable ATA_16 passthru for ATAPI devices (0=off, 1=on [default])"); -int libata_fua = 0; +int libata_fua = 1; module_param_named(fua, libata_fua, int, 0444); -MODULE_PARM_DESC(fua, "FUA support (0=off [default], 1=on)"); +MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on [default])"); static int ata_ignore_hpa; module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);