Patchwork [GIT,PULL] omap fixes for v3.4-rc6

login
register
mail settings
Submitter Tony Lindgren
Date May 7, 2012, 10:36 p.m.
Message ID <20120507223632.GP5088@atomide.com>
Download mbox
Permalink /patch/157480/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-fixes-for-v3.4-rc6

Comments

Tony Lindgren - May 7, 2012, 10:36 p.m.
The following changes since commit 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:

  Linux 3.4-rc5 (2012-04-29 15:19:10 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-fixes-for-v3.4-rc6

for you to fetch changes up to 4d975027cc327d4486bb74b6908e874f2fee8c47:

  ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally (2012-05-04 12:45:21 -0700)

----------------------------------------------------------------
Few more regression fixes that are mostly board specific

----------------------------------------------------------------
Archit Taneja (1):
      ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields"

Enrico Butera (1):
      ARM: OMAP: igep0020: fix smsc911x dummy regulator id

Janusz Krzysztofik (1):
      ARM: OMAP1: Amstrad Delta: Fix wrong IRQ base in FIQ handler

Laurent Pinchart (1):
      ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally

 arch/arm/mach-omap1/ams-delta-fiq.c                |    2 +-
 arch/arm/mach-omap2/board-igep0020.c               |   12 ++++++------
 .../include/mach/ctrl_module_pad_core_44xx.h       |    8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)
Olof Johansson - May 9, 2012, 6:48 a.m.
Hi,

On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <tony@atomide.com> wrote:
> The following changes since commit 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:
[..]
> Enrico Butera (1):
>      ARM: OMAP: igep0020: fix smsc911x dummy regulator id

Hmm. Picking 40 without any kind of comment in the code isn't doing
any favors for future readers. Seems like 1 would be free on this
board, from the rest of the board file to judge (one other
reg-fixed-regulator platform device)?

Please either comment why you picked 40 (i.e. it's a random number),
or change it to something a little less random like 1. :)

> Laurent Pinchart (1):
>      ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally

Is this a regression? I don't see any recent changes regarding this,
so it's hard to tell. If not then I'd rather hold off for the merge
window given that we're at -rc6.


-Olof
Enrico - May 9, 2012, 8:32 a.m.
On Wed, May 9, 2012 at 8:48 AM, Olof Johansson <olof@lixom.net> wrote:
> Hi,
>
> On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <tony@atomide.com> wrote:
>> The following changes since commit 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:
> [..]
>> Enrico Butera (1):
>>      ARM: OMAP: igep0020: fix smsc911x dummy regulator id
>
> Hmm. Picking 40 without any kind of comment in the code isn't doing
> any favors for future readers. Seems like 1 would be free on this
> board, from the rest of the board file to judge (one other
> reg-fixed-regulator platform device)?
>
> Please either comment why you picked 40 (i.e. it's a random number),
> or change it to something a little less random like 1. :)

Yes i verified that 1 is free, i will send an updated patch.

Enrico
Laurent Pinchart - May 9, 2012, 11:05 a.m.
Hi Olof,

On Tuesday 08 May 2012 23:48:06 Olof Johansson wrote:
> Hi,
> 
> On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <tony@atomide.com> wrote:
> > The following changes since commit 
69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:
> [..]
> 
> > Enrico Butera (1):
> >      ARM: OMAP: igep0020: fix smsc911x dummy regulator id
> 
> Hmm. Picking 40 without any kind of comment in the code isn't doing
> any favors for future readers. Seems like 1 would be free on this
> board, from the rest of the board file to judge (one other
> reg-fixed-regulator platform device)?
> 
> Please either comment why you picked 40 (i.e. it's a random number),
> or change it to something a little less random like 1. :)
> 
> > Laurent Pinchart (1):
> >      ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally
> 
> Is this a regression? I don't see any recent changes regarding this,
> so it's hard to tell. If not then I'd rather hold off for the merge
> window given that we're at -rc6.

It's not a regression, I'm fine with holding off until the v3.5 merge window.
Tony Lindgren - May 9, 2012, 3:15 p.m.
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [120509 04:09]:
> Hi Olof,
> 
> On Tuesday 08 May 2012 23:48:06 Olof Johansson wrote:
> > Hi,
> > 
> > On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <tony@atomide.com> wrote:
> > > The following changes since commit 
> 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:
> > [..]
> > 
> > > Enrico Butera (1):
> > >      ARM: OMAP: igep0020: fix smsc911x dummy regulator id
> > 
> > Hmm. Picking 40 without any kind of comment in the code isn't doing
> > any favors for future readers. Seems like 1 would be free on this
> > board, from the rest of the board file to judge (one other
> > reg-fixed-regulator platform device)?
> > 
> > Please either comment why you picked 40 (i.e. it's a random number),
> > or change it to something a little less random like 1. :)

I'll use the update patch from Enrico.

> > > Laurent Pinchart (1):
> > >      ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally
> > 
> > Is this a regression? I don't see any recent changes regarding this,
> > so it's hard to tell. If not then I'd rather hold off for the merge
> > window given that we're at -rc6.
> 
> It's not a regression, I'm fine with holding off until the v3.5 merge window.

And will move this one into fixes-non-critical.

Will send a new pull request shortly.

Tony