From patchwork Mon May 7 16:56:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,2/4] jffs2: remove unnecessary GC pass on umount From: Artem Bityutskiy X-Patchwork-Id: 157355 Message-Id: <1336409813-6365-3-git-send-email-dedekind1@gmail.com> To: David Woodhouse , MTD Maling List Cc: Linux Kernel Maling List Date: Mon, 7 May 2012 19:56:51 +0300 From: Artem Bityutskiy We do not need to call 'jffs2_write_super()' on unmount. This function causes a GC pass to make sure the current contents is pushed out with the data which we already have on the media. But this is not needed on unmount and only slows unmount down unnecessarily. It is enough to just sync the write-buffer. This call was added by one of the generic VFS rework patch-sets, see 8c85e125124a473d6f3e9bb187b0b84207f81d91. Signed-off-by: Artem Bityutskiy --- fs/jffs2/super.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index 3422a2d..d3dc9d8 100644 --- a/fs/jffs2/super.c +++ b/fs/jffs2/super.c @@ -316,9 +316,6 @@ static void jffs2_put_super (struct super_block *sb) jffs2_dbg(2, "%s()\n", __func__); - if (sb->s_dirt) - jffs2_write_super(sb); - mutex_lock(&c->alloc_sem); jffs2_flush_wbuf_pad(c); mutex_unlock(&c->alloc_sem);