Patchwork [v2,2/4] jffs2: remove unnecessary GC pass on umount

login
register
mail settings
Submitter Artem Bityutskiy
Date May 7, 2012, 4:56 p.m.
Message ID <1336409813-6365-3-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/157355/
State New
Headers show

Comments

Artem Bityutskiy - May 7, 2012, 4:56 p.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

We do not need to call 'jffs2_write_super()' on unmount. This function
causes a GC pass to make sure the current contents is pushed out with
the data which we already have on the media.

But this is not needed on unmount and only slows unmount down unnecessarily.
It is enough to just sync the write-buffer.

This call was added by one of the generic VFS rework patch-sets,
see 8c85e125124a473d6f3e9bb187b0b84207f81d91.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/jffs2/super.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Patch

diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 3422a2d..d3dc9d8 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -316,9 +316,6 @@  static void jffs2_put_super (struct super_block *sb)
 
 	jffs2_dbg(2, "%s()\n", __func__);
 
-	if (sb->s_dirt)
-		jffs2_write_super(sb);
-
 	mutex_lock(&c->alloc_sem);
 	jffs2_flush_wbuf_pad(c);
 	mutex_unlock(&c->alloc_sem);