Patchwork [v2,3/4] jffs2: remove unnecessary GC pass on sync

login
register
mail settings
Submitter Artem Bityutskiy
Date May 7, 2012, 4:56 p.m.
Message ID <1336409813-6365-4-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/157354/
State New
Headers show

Comments

Artem Bityutskiy - May 7, 2012, 4:56 p.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

We do not need to call 'jffs2_write_super()' on sync. This function
causes a GC pass to make sure the current contents is pushed out with
the data which we already have on the media.

But this is not needed on unmount and only slows sync down unnecessarily.
It is enough to just sync the write-buffer.

This call was added by one of the generic VFS rework patch-sets,
see d579ed00aa96a7f7486978540a0d7cecaff742ae.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/jffs2/super.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Patch

diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index d3dc9d8..dc366c0 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -110,8 +110,6 @@  static int jffs2_sync_fs(struct super_block *sb, int wait)
 {
 	struct jffs2_sb_info *c = JFFS2_SB_INFO(sb);
 
-	jffs2_write_super(sb);
-
 	mutex_lock(&c->alloc_sem);
 	jffs2_flush_wbuf_pad(c);
 	mutex_unlock(&c->alloc_sem);