From patchwork Fri May 4 23:30:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: P2P: Fix Ctrl interfance for parsing of command p2p_connect Date: Fri, 04 May 2012 13:30:56 -0000 From: nirav shah X-Patchwork-Id: 157010 Message-Id: <5A7EE8205ACF264A834A5C987038F7B81A1B3658@FMSMSX103.amr.corp.intel.com> To: "hostap@lists.shmoo.com" I think I might have made a mistake here. my patch breaks normal p2p group formation. So don't accept this version of this patch. The reason I did this is I am trying to figure out how p2p_invite works for non persistent groups. I was trying to do "p2p_connect join auth" to pre-authorize a peer to invite this instance to a group (non-persistent). But I looked at this /* <"pbc" | "pin" | PIN> [label|display|keypad] [persistent] * [join] [auth] [go_intent=<0..15>] [freq=] */ and I realized that command is not accepted because p2p_connect expects <"pbc" | "pin" | PIN> Does p2p_connect need wps authentication. If so how should I be doing this? Thanks, Nirav. -----Original Message----- From: Shah, Nirav J2 Sent: Friday, May 04, 2012 3:30 PM To: hostap@lists.shmoo.com Cc: Shah, Nirav J2 Subject: [PATCH] P2P: Fix Ctrl interfance for parsing of command p2p_connect The ctrl interface does not recognize the command following peer address as it moves past a ' '(space) which it looks for later on in os_strstr. Signed-hostap: Nirav Shah intended-for: hostap-1 --- wpa_supplicant/ctrl_iface.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index 538f8df..00f3614 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -2800,7 +2800,6 @@ static int p2p_ctrl_connect(struct wpa_supplicant *wpa_s, char *cmd, pos = cmd + 17; if (*pos != ' ') return -1; - pos++; persistent_group = os_strstr(pos, " persistent") != NULL; pos2 = os_strstr(pos, " persistent=");