From patchwork Thu May 3 07:02:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dunrong huang X-Patchwork-Id: 156770 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EC491B6FC2 for ; Fri, 4 May 2012 06:23:24 +1000 (EST) Received: from localhost ([::1]:60874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ2Yc-00057N-8R for incoming@patchwork.ozlabs.org; Thu, 03 May 2012 16:23:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPq35-0006S4-NP for qemu-devel@nongnu.org; Thu, 03 May 2012 03:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPq33-0006Qe-RO for qemu-devel@nongnu.org; Thu, 03 May 2012 03:01:59 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:36996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPq33-0006QG-Jg; Thu, 03 May 2012 03:01:57 -0400 Received: by dady13 with SMTP id y13so1197882dad.5 for ; Thu, 03 May 2012 00:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=asnpkqicstGZo2q6fAWZXgdmQQGGgvtmw8vxWiDrKxs=; b=bR5ZCJuJq/kBJXmUERy05U0bqEh8KUurBFoB5tF8MsarnkMpdfnmQePftfyuQVZcvX 0MLve5JYERIGwRPG31WrSAalGCfoFwxjHtE9OJtXAdD3ywL3iZpSciKLyDOrVXJJ4B1c cYmT5S1ojXXVdGMZ1sJKE3YoEpfjo355cPh/2yYDJ0qFhHm8vwqKZ0dGoh79FzuGg7YV sJWAKRCJGUHtp57V/uPGz5XIBCGY6/MDUdRJQxyDJDZ1kNwtaQ9JazTveuiiQF47nH6p BKKGGdO/7a+ltml8UxTzThCuGkuAVQLhKvyHnAFgKiceiErbZvaANRKN4KxGK+5oIacZ 6aGg== Received: by 10.68.216.225 with SMTP id ot1mr4666545pbc.46.1336028513971; Thu, 03 May 2012 00:01:53 -0700 (PDT) Received: from riegamaths@gmail.com ([119.255.44.227]) by mx.google.com with ESMTPS id oj3sm1544389pbb.20.2012.05.03.00.01.48 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 May 2012 00:01:52 -0700 (PDT) Received: by riegamaths@gmail.com (sSMTP sendmail emulation); Thu, 03 May 2012 15:02:24 +0800 From: dunrong huang To: qemu-devel@nongnu.org Date: Thu, 3 May 2012 15:02:22 +0800 Message-Id: <1336028542-785-1-git-send-email-riegamaths@gmail.com> X-Mailer: git-send-email 1.7.8.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.46 X-Mailman-Approved-At: Thu, 03 May 2012 16:23:14 -0400 Cc: qemu-trivial@nongnu.org, dunrong huang Subject: [Qemu-devel] [PATCH] qdev: Fix memory leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The str allocated in visit_type_str was not freed Signed-off-by: dunrong huang --- hw/qdev-properties.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 98dd06a..8088699 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -726,7 +726,7 @@ static void set_mac(Object *obj, Visitor *v, void *opaque, MACAddr *mac = qdev_get_prop_ptr(dev, prop); Error *local_err = NULL; int i, pos; - char *str, *p; + char *str = NULL, *p; if (dev->state != DEV_STATE_CREATED) { error_set(errp, QERR_PERMISSION_DENIED); @@ -753,10 +753,12 @@ static void set_mac(Object *obj, Visitor *v, void *opaque, } mac->a[i] = strtol(str+pos, &p, 16); } + g_free(str); return; inval: error_set_from_qdev_prop_error(errp, EINVAL, dev, prop, str); + g_free(str); } PropertyInfo qdev_prop_macaddr = { @@ -825,7 +827,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, void *opaque, uint32_t *ptr = qdev_get_prop_ptr(dev, prop); unsigned int slot, fn, n; Error *local_err = NULL; - char *str = (char *)""; + char *str = NULL; if (dev->state != DEV_STATE_CREATED) { error_set(errp, QERR_PERMISSION_DENIED); @@ -847,10 +849,12 @@ static void set_pci_devfn(Object *obj, Visitor *v, void *opaque, goto invalid; } *ptr = slot << 3 | fn; + g_free(str); return; invalid: error_set_from_qdev_prop_error(errp, EINVAL, dev, prop, str); + g_free(str); } static int print_pci_devfn(DeviceState *dev, Property *prop, char *dest, size_t len)