Patchwork mtd-utils: Better document --pagesize of mkfs.jffs2

login
register
mail settings
Submitter Shmulik Ladkani
Date May 3, 2012, 6:59 p.m.
Message ID <20120503215959.374d0c34@halley>
Download mbox | patch
Permalink /patch/156763/
State Accepted
Commit 21e10ce956a900a08a9df1a780af1246103f0f0f
Headers show

Comments

Shmulik Ladkani - May 3, 2012, 6:59 p.m.
Add a strict explanation '--pagesize' refers to target system's mm page
size.

Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
---

This is according to the below discussion:
http://lists.infradead.org/pipermail/linux-mtd/2012-May/041233.html
Artem Bityutskiy - May 4, 2012, 8:29 a.m.
On Thu, 2012-05-03 at 21:59 +0300, Shmulik Ladkani wrote:
> Add a strict explanation '--pagesize' refers to target system's mm page
> size.
> 
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>

Pushed to mtd-utils.git, thanks!

Patch

diff --git a/mkfs.jffs2.1 b/mkfs.jffs2.1
index 9b0acc3..47a3ac7 100644
--- a/mkfs.jffs2.1
+++ b/mkfs.jffs2.1
@@ -137,7 +137,8 @@  directory.
 .TP
 .B -s, --pagesize=SIZE
 Use page size SIZE.  The default is 4 KiB.  This size is the
-maximum size of a data node.
+maximum size of a data node.  Set according to target system's memory
+management page size (NOTE: this is NOT related to NAND page size).
 .TP
 .B -e, --eraseblock=SIZE
 Use erase block size SIZE.  The default is 64 KiB.  If you use a erase
diff --git a/mkfs.jffs2.c b/mkfs.jffs2.c
index ad88ac6..d170a04 100644
--- a/mkfs.jffs2.c
+++ b/mkfs.jffs2.c
@@ -1391,7 +1391,9 @@  static const char helptext[] =
 "                          not specified, the output is padded to the end of\n"
 "                          the final erase block\n"
 "  -r, -d, --root=DIR      Build file system from directory DIR (default: cwd)\n"
-"  -s, --pagesize=SIZE     Use page size (max data node size) SIZE (default: 4KiB)\n"
+"  -s, --pagesize=SIZE     Use page size (max data node size) SIZE.\n"
+"                          Set according to target system's memory management\n"
+"                          page size (default: 4KiB)\n"
 "  -e, --eraseblock=SIZE   Use erase block size SIZE (default: 64KiB)\n"
 "  -c, --cleanmarker=SIZE  Size of cleanmarker (default 12)\n"
 "  -m, --compr-mode=MODE   Select compression mode (default: priortiry)\n"