[U-Boot] checkpatch: add check for whitespace before semicolon at end-of-line

Submitted by Eric Nelson on May 3, 2012, 3:32 a.m.

Details

Message ID 1336015938-3174-1-git-send-email-eric.nelson@boundarydevices.com
State Accepted
Headers show

Commit Message

Eric Nelson May 3, 2012, 3:32 a.m.
This tests for a bad habits of mine like this:

	return 0 ;

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 scripts/checkpatch.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Joe Perches May 3, 2012, 3:58 a.m.
On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
> This tests for a bad habits of mine like this:
> 
> 	return 0 ;
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  scripts/checkpatch.pl |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a3b9782..0e6977e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3227,6 +3227,12 @@ sub process {
>  			 "Statements terminations use 1 semicolon\n" . $herecurr);
>  		}
>  
> +# check for whitespace before semicolon - not allowed at end-of-line
> +		if ($line =~ /\s+;$/) {

		if ($line =~ /\s+;\s*$/)

> +		    WARN("SPACEBEFORE_SEMICOLON",

		    WARN("SPACING",
	
> +			 "Whitespace before semicolon\n" . $herecurr);
> +		}
> +
Eric Nelson May 3, 2012, 1:41 p.m.
Thanks Joe,

On 05/02/2012 08:58 PM, Joe Perches wrote:
> On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote:
>> This tests for a bad habits of mine like this:
>>
>> 	return 0 ;
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>>   scripts/checkpatch.pl |    6 ++++++
>>   1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a3b9782..0e6977e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3227,6 +3227,12 @@ sub process {
>>   			 "Statements terminations use 1 semicolon\n" . $herecurr);
>>   		}
>>
>> +# check for whitespace before semicolon - not allowed at end-of-line
>> +		if ($line =~ /\s+;$/) {
>
> 		if ($line =~ /\s+;\s*$/)
>
Won't the extra space at end of line be caught by other tests?

>> +		    WARN("SPACEBEFORE_SEMICOLON",
>
> 		WARN("SPACING",
>
Joe Perches May 3, 2012, 3:52 p.m.
On Thu, 2012-05-03 at 06:41 -0700, Eric Nelson wrote:
> >> +# check for whitespace before semicolon - not allowed at end-of-line
> >> +		if ($line =~ /\s+;$/) {
> >
> > 		if ($line =~ /\s+;\s*$/)

> Won't the extra space at end of line be caught by other tests?

Yes it will.

You want the test to find the space before semicolon
whenever it exists.
Wolfgang Denk June 21, 2012, 7:30 p.m.
Dear Eric Nelson,

In message <1336015938-3174-1-git-send-email-eric.nelson@boundarydevices.com> you wrote:
> This tests for a bad habits of mine like this:
> 
> 	return 0 ;
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  scripts/checkpatch.pl |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

Applied to tools/checkpatch.pl, thanks.

Best regards,

Wolfgang Denk

Patch hide | download patch | download mbox

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a3b9782..0e6977e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3227,6 +3227,12 @@  sub process {
 			 "Statements terminations use 1 semicolon\n" . $herecurr);
 		}
 
+# check for whitespace before semicolon - not allowed at end-of-line
+		if ($line =~ /\s+;$/) {
+		    WARN("SPACEBEFORE_SEMICOLON",
+			 "Whitespace before semicolon\n" . $herecurr);
+		}
+
 # check for gcc specific __FUNCTION__
 		if ($line =~ /__FUNCTION__/) {
 			WARN("USE_FUNC",