From patchwork Wed May 2 17:15:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 156508 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D0F55B6FA5 for ; Thu, 3 May 2012 03:18:25 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SPdAi-00033F-VP; Wed, 02 May 2012 17:17:01 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SPdA4-0002kp-KR for linux-mtd@lists.infradead.org; Wed, 02 May 2012 17:16:21 +0000 Received: by mail-pb0-f49.google.com with SMTP id rq13so1447778pbb.36 for ; Wed, 02 May 2012 10:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=497fOub73JgaS/1p3QKJVQr/LupsgVAbRrqYpzrEPdQ=; b=Bmhpm4i5scvNVL0/Yz9bmcvWeizdvKC21r+TFBKvF85wnv8fn4vkROmO7j1l0wqWUs PHQyX6b8HcVgX2abaBzrcJ2VAfdJ3AZRk08YNOp7Aie/z3BBe+tKu0v3UCs3tdKiw0Xh 4GMLneNeY/0/WejPmwtRGpsP8gC5lBc5urQfmOKFiItNcRswt2ck9fO2cT+JFcja6z8s z60t12MTG9ywjI0TsFkG6WxnCDzy0/a6Fqw2Sntb5gyCZrQ0VRpA0JOxPq6ogbJ5gIGF N3ut70NUdtyWrujxTMTDRTdVQEaakqy1sklKXEyHvjGkN2vqPMFHuALX5mIxyO2SKyO0 wHGA== Received: by 10.68.136.69 with SMTP id py5mr21525995pbb.115.1335978980379; Wed, 02 May 2012 10:16:20 -0700 (PDT) Received: from localhost.localdomain (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPS id mr6sm2484662pbb.29.2012.05.02.10.16.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 May 2012 10:16:19 -0700 (PDT) From: Brian Norris To: Subject: [PATCH v4 07/10] mtd: IFC NAND: utilize oob_required parameter Date: Wed, 2 May 2012 10:15:01 -0700 Message-Id: <1335978904-8005-8-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 1.7.5.4.2.g519b1 In-Reply-To: <1335978904-8005-1-git-send-email-computersforpeace@gmail.com> References: <1335978904-8005-1-git-send-email-computersforpeace@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Scott Wood , Brian Norris , David Woodhouse , Li Yang , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Don't read OOB if the caller doesn't require it. Signed-off-by: Brian Norris Reviewed-by: Scott Wood --- drivers/mtd/nand/fsl_ifc_nand.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c index c085df3..9602c1b 100644 --- a/drivers/mtd/nand/fsl_ifc_nand.c +++ b/drivers/mtd/nand/fsl_ifc_nand.c @@ -706,7 +706,8 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip, struct fsl_ifc_nand_ctrl *nctrl = ifc_nand_ctrl; fsl_ifc_read_buf(mtd, buf, mtd->writesize); - fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize); + if (oob_required) + fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize); if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER) dev_err(priv->dev, "NAND Flash ECC Uncorrectable Error\n");