Patchwork [v3,02/10] ARM: sh-mobile: mackerel: Add error IRQ resource

login
register
mail settings
Submitter Bastian Hecht
Date May 2, 2012, 9:41 a.m.
Message ID <1335951710-9390-3-git-send-email-hechtb@gmail.com>
Download mbox | patch
Permalink /patch/156401/
State New
Headers show

Comments

Bastian Hecht - May 2, 2012, 9:41 a.m.
Supply the platform data for the FLSTEI error IRQ.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Rafael J. Wysocki - May 2, 2012, 8:49 p.m.
On Wednesday, May 02, 2012, Bastian Hecht wrote:
> Supply the platform data for the FLSTEI error IRQ.
> 
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>

I'm going to take this patch into the renesas.git tree and push it
upstream throuch arm-soc, if that's not a problem.

Thanks,
Rafael


> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 8758f94..1de1fb7 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -990,7 +990,11 @@ static struct resource nand_flash_resources[] = {
>  		.start	= 0xe6a30000,
>  		.end	= 0xe6a3009b,
>  		.flags	= IORESOURCE_MEM,
> -	}
> +	},
> +	[1] = {
> +		.start	= evt2irq(0x0d80), /* flstei: status error irq */
> +		.flags	= IORESOURCE_IRQ,
> +	},
>  };
>  
>  static struct sh_flctl_platform_data nand_flash_data = {
>
Magnus Damm - May 2, 2012, 9:03 p.m.
2012/5/3 Rafael J. Wysocki <rjw@sisk.pl>:
> On Wednesday, May 02, 2012, Bastian Hecht wrote:
>> Supply the platform data for the FLSTEI error IRQ.
>>
>> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
>
> I'm going to take this patch into the renesas.git tree and push it
> upstream throuch arm-soc, if that's not a problem.

Sure, that's fine. Seems like a rather clear case of a mach-shmobile
patch without any special dependencies.

Cheers,

/ magnus
Artem Bityutskiy - May 3, 2012, 6 a.m.
On Wed, 2012-05-02 at 22:49 +0200, Rafael J. Wysocki wrote:
> On Wednesday, May 02, 2012, Bastian Hecht wrote:
> > Supply the platform data for the FLSTEI error IRQ.
> > 
> > Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> 
> I'm going to take this patch into the renesas.git tree and push it
> upstream throuch arm-soc, if that's not a problem.

It is already in the MTD tree with the rest of the 10 patches...
Artem Bityutskiy - May 3, 2012, 6:01 a.m.
On Thu, 2012-05-03 at 09:00 +0300, Artem Bityutskiy wrote:
> On Wed, 2012-05-02 at 22:49 +0200, Rafael J. Wysocki wrote:
> > On Wednesday, May 02, 2012, Bastian Hecht wrote:
> > > Supply the platform data for the FLSTEI error IRQ.
> > > 
> > > Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> > 
> > I'm going to take this patch into the renesas.git tree and push it
> > upstream throuch arm-soc, if that's not a problem.
> 
> It is already in the MTD tree with the rest of the 10 patches...

Ops, sorry, this is not true. Then Bastian should separate it out and
not send it to the MTD tree.
Bastian Hecht - May 3, 2012, 9:29 a.m.
Am 03.05.2012 08:01 schrieb "Artem Bityutskiy" <dedekind1@gmail.com>:
>
> On Thu, 2012-05-03 at 09:00 +0300, Artem Bityutskiy wrote:
> > On Wed, 2012-05-02 at 22:49 +0200, Rafael J. Wysocki wrote:
> > > On Wednesday, May 02, 2012, Bastian Hecht wrote:
> > > > Supply the platform data for the FLSTEI error IRQ.
> > > >
> > > > Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> > >
> > > I'm going to take this patch into the renesas.git tree and push it
> > > upstream throuch arm-soc, if that's not a problem.
> >
> > It is already in the MTD tree with the rest of the 10 patches...
>
> Ops, sorry, this is not true. Then Bastian should separate it out and
> not send it to the MTD tree.

Alright I'll do. I need to fix the compiler warnings of the mtd patches
anyway. So the board code is independant and can be pushed already by
Rafael, right? How is it supposed to work in general? I think the sh-mobile
list wants to be informed when I change something in the flctl code. Would
the right approach be to send 2 patchsets - posted on both MLs so that
Artem can take the mtd portions and Rafael the mackerel ones?

Best regards,

Bastian Hecht

> --
> Best Regards,
> Artem Bityutskiy
Artem Bityutskiy - May 3, 2012, 10:05 a.m.
On Thu, 2012-05-03 at 11:29 +0200, Bastian Hecht wrote:
> 
> Am 03.05.2012 08:01 schrieb "Artem Bityutskiy" <dedekind1@gmail.com>:
> >
> > On Thu, 2012-05-03 at 09:00 +0300, Artem Bityutskiy wrote:
> > > On Wed, 2012-05-02 at 22:49 +0200, Rafael J. Wysocki wrote:
> > > > On Wednesday, May 02, 2012, Bastian Hecht wrote:
> > > > > Supply the platform data for the FLSTEI error IRQ.
> > > > >
> > > > > Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> > > >
> > > > I'm going to take this patch into the renesas.git tree and push
> it
> > > > upstream throuch arm-soc, if that's not a problem.
> > >
> > > It is already in the MTD tree with the rest of the 10 patches...
> >
> > Ops, sorry, this is not true. Then Bastian should separate it out
> and
> > not send it to the MTD tree.
> 
> Alright I'll do. I need to fix the compiler warnings of the mtd
> patches anyway. So the board code is independant and can be pushed
> already by Rafael, right? How is it supposed to work in general? I
> think the sh-mobile list wants to be informed when I change something
> in the flctl code. Would the right approach be to send 2 patchsets -
> posted on both MLs so that Artem can take the mtd portions and Rafael
> the mackerel ones?

If the patches are completely independent, post them separately. I think
it is also OK to CC more than one mailing list.
Rafael J. Wysocki - May 3, 2012, 1:31 p.m.
On Thursday, May 03, 2012, Artem Bityutskiy wrote:
> On Thu, 2012-05-03 at 11:29 +0200, Bastian Hecht wrote:
> > 
> > Am 03.05.2012 08:01 schrieb "Artem Bityutskiy" <dedekind1@gmail.com>:
> > >
> > > On Thu, 2012-05-03 at 09:00 +0300, Artem Bityutskiy wrote:
> > > > On Wed, 2012-05-02 at 22:49 +0200, Rafael J. Wysocki wrote:
> > > > > On Wednesday, May 02, 2012, Bastian Hecht wrote:
> > > > > > Supply the platform data for the FLSTEI error IRQ.
> > > > > >
> > > > > > Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> > > > >
> > > > > I'm going to take this patch into the renesas.git tree and push
> > it
> > > > > upstream throuch arm-soc, if that's not a problem.
> > > >
> > > > It is already in the MTD tree with the rest of the 10 patches...
> > >
> > > Ops, sorry, this is not true. Then Bastian should separate it out
> > and
> > > not send it to the MTD tree.
> > 
> > Alright I'll do. I need to fix the compiler warnings of the mtd
> > patches anyway. So the board code is independant and can be pushed
> > already by Rafael, right? How is it supposed to work in general? I
> > think the sh-mobile list wants to be informed when I change something
> > in the flctl code. Would the right approach be to send 2 patchsets -
> > posted on both MLs so that Artem can take the mtd portions and Rafael
> > the mackerel ones?
> 
> If the patches are completely independent, post them separately.

Yes, please.

> I think it is also OK to CC more than one mailing list.

Yes, it is.

Thanks,
Rafael

Patch

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 8758f94..1de1fb7 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -990,7 +990,11 @@  static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {