| Message ID | 1335913584-13221-1-git-send-email-eric.nelson@boundarydevices.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Eric Nelson, > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> > --- > tools/checkpatch.pl | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl > index 2048a44..0caffcb 100755 > --- a/tools/checkpatch.pl > +++ b/tools/checkpatch.pl > @@ -3139,6 +3139,12 @@ sub process { > "Statements terminations use 1 semicolon\n" . $herecurr); > } > > +# check for whitespace before semicolon (not allowed at end-of-line) > + if ($line =~ /\s+;$/) { > + WARN("SPACEBEFORE_SEMICOLON", > + "Blank before semicolon\n" . $herecurr); > + } > + > # check for gcc specific __FUNCTION__ > if ($line =~ /__FUNCTION__/) { > WARN("USE_FUNC", Coolness, now let's also CC the linux (upstream) checkpatch author, to get it properly upstreamed :) For me, add Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 05/01/2012 04:11 PM, Marek Vasut wrote: > Dear Eric Nelson, > >> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com> >> --- >> tools/checkpatch.pl | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl >> index 2048a44..0caffcb 100755 >> --- a/tools/checkpatch.pl >> +++ b/tools/checkpatch.pl >> @@ -3139,6 +3139,12 @@ sub process { >> "Statements terminations use 1 semicolon\n" . > $herecurr); >> } >> >> +# check for whitespace before semicolon (not allowed at end-of-line) >> + if ($line =~ /\s+;$/) { >> + WARN("SPACEBEFORE_SEMICOLON", >> + "Blank before semicolon\n" . $herecurr); >> + } >> + >> # check for gcc specific __FUNCTION__ >> if ($line =~ /__FUNCTION__/) { >> WARN("USE_FUNC", > > Coolness, now let's also CC the linux (upstream) checkpatch author, to get it > properly upstreamed :) > That looks to be Andy. It's not clear to me that this is a style violation though: http://www.kernel.org/doc/Documentation/CodingStyle Andy, we're discussing the inclusion of a test in checkpatch for space before semicolon at the end-of line to catch my bad habits like this: return 0 ; > For me, add > Acked-by: Marek Vasut<marex@denx.de> >
diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 2048a44..0caffcb 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -3139,6 +3139,12 @@ sub process { "Statements terminations use 1 semicolon\n" . $herecurr); } +# check for whitespace before semicolon (not allowed at end-of-line) + if ($line =~ /\s+;$/) { + WARN("SPACEBEFORE_SEMICOLON", + "Blank before semicolon\n" . $herecurr); + } + # check for gcc specific __FUNCTION__ if ($line =~ /__FUNCTION__/) { WARN("USE_FUNC",
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> --- tools/checkpatch.pl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)