Patchwork [U-Boot] checkpatch: warn of whitespace before semicolon at end of line.

login
register
mail settings
Submitter Eric Nelson
Date May 1, 2012, 10:06 p.m.
Message ID <1335909976-25504-1-git-send-email-eric.nelson@boundarydevices.com>
Download mbox | patch
Permalink /patch/156249/
State Changes Requested
Delegated to: Marek Vasut
Headers show

Comments

Eric Nelson - May 1, 2012, 10:06 p.m.
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 tools/checkpatch.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Marek Vasut - May 1, 2012, 10:27 p.m.
Dear Eric Nelson,

> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  tools/checkpatch.pl |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 2048a44..0caffcb 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -3139,6 +3139,12 @@ sub process {
>  			 "Statements terminations use 1 semicolon\n" . 
$herecurr);
>  		}
> 
> +# check for multiple semicolons

Are you sure about the comment ^ ;-)

> +		if ($line =~ /\s+;$/) {
> +		    WARN("SPACEBEFORE_SEMICOLON",
> +			 "Blank before semicolon\n" . $herecurr);
> +		}
> +
>  # check for gcc specific __FUNCTION__
>  		if ($line =~ /__FUNCTION__/) {
>  			WARN("USE_FUNC",

Best regards,
Marek Vasut
Mike Frysinger - May 3, 2012, 3 a.m.
On Tuesday 01 May 2012 18:06:16 Eric Nelson wrote:
>  tools/checkpatch.pl |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

should be sent to lkml/kbuild lists ...
-mike
Eric Nelson - May 3, 2012, 3:24 a.m.
On 05/02/2012 08:00 PM, Mike Frysinger wrote:
> On Tuesday 01 May 2012 18:06:16 Eric Nelson wrote:
>>   tools/checkpatch.pl |    6 ++++++
>>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> should be sent to lkml/kbuild lists ...
> -mike

Thanks for the pointer Mike.

Patch

diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
index 2048a44..0caffcb 100755
--- a/tools/checkpatch.pl
+++ b/tools/checkpatch.pl
@@ -3139,6 +3139,12 @@  sub process {
 			 "Statements terminations use 1 semicolon\n" . $herecurr);
 		}
 
+# check for multiple semicolons
+		if ($line =~ /\s+;$/) {
+		    WARN("SPACEBEFORE_SEMICOLON",
+			 "Blank before semicolon\n" . $herecurr);
+		}
+
 # check for gcc specific __FUNCTION__
 		if ($line =~ /__FUNCTION__/) {
 			WARN("USE_FUNC",