Patchwork [3/7] arch/powerpc/platforms/pasemi: Use DEFINE_SPINLOCK

login
register
mail settings
Submitter Julia Lawall
Date Dec. 25, 2008, 2:34 p.m.
Message ID <Pine.LNX.4.64.0812251533350.22039@ask.diku.dk>
Download mbox | patch
Permalink /patch/15601/
State Accepted
Commit 1d5bc03a8183d12c7daf4e7c69cce8d9c4b9a86b
Headers show

Comments

Julia Lawall - Dec. 25, 2008, 2:34 p.m.
From: Julia Lawall <julia@diku.dk>

SPIN_LOCK_UNLOCKED is deprecated.  The following makes the change suggested
in Documentation/spinlocks.txt

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
declarer name DEFINE_SPINLOCK;
identifier xxx_lock;
@@

- spinlock_t xxx_lock = SPIN_LOCK_UNLOCKED;
+ DEFINE_SPINLOCK(xxx_lock);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---

Patch

diff -u -p a/arch/powerpc/platforms/pasemi/dma_lib.c b/arch/powerpc/platforms/pasemi/dma_lib.c
--- a/arch/powerpc/platforms/pasemi/dma_lib.c
+++ b/arch/powerpc/platforms/pasemi/dma_lib.c
@@ -509,7 +509,7 @@  fallback:
  */
 int pasemi_dma_init(void)
 {
-	static spinlock_t init_lock = SPIN_LOCK_UNLOCKED;
+	static DEFINE_SPINLOCK(init_lock);
 	struct pci_dev *iob_pdev;
 	struct pci_dev *pdev;
 	struct resource res;