Patchwork [resend] directfb: add support for davinci gfx driver

login
register
mail settings
Submitter Arnout Vandecappelle
Date April 28, 2012, 4:50 p.m.
Message ID <1335631844-15681-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/155673/
State Accepted
Commit df39ffe7f437f62d7c0eb6d73bdb86b2d09a8c8a
Headers show

Comments

Arnout Vandecappelle - April 28, 2012, 4:50 p.m.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/directfb/Config.in   |    4 ++++
 package/directfb/directfb.mk |    3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Peter Korsgaard - May 1, 2012, 8:02 p.m.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.
Peter Korsgaard - May 5, 2012, 9:05 a.m.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Arnout> ---
 Arnout>  package/directfb/Config.in   |    4 ++++
 Arnout>  package/directfb/directfb.mk |    3 ++-
 Arnout>  2 files changed, 6 insertions(+), 1 deletion(-)

This seems to fail on the autobuilder:

http://autobuild.buildroot.org/results/d5c2cb226757a8bf90dac33bd04f87f325654220/build-end.log

For some odd reason, I don't see the davincifb.h file in the directfb
tarball, but it IS in git:

http://git.directfb.org/?p=core/DirectFB.git;a=tree;f=gfxdrivers/davinci;h=f0bd9ad6add6164f3a5e953d4eed4056315a2be2;hb=ab0d779e85cec22c7c2e7b8b6b1976049b1ba0f1

Is it working for you? If so, how?
Arnout Vandecappelle - May 6, 2012, 11:27 a.m.
On 05/05/12 11:05, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>  writes:
>
>   Arnout>  Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
>   Arnout>  ---
>   Arnout>   package/directfb/Config.in   |    4 ++++
>   Arnout>   package/directfb/directfb.mk |    3 ++-
>   Arnout>   2 files changed, 6 insertions(+), 1 deletion(-)
>
> This seems to fail on the autobuilder:
>
> http://autobuild.buildroot.org/results/d5c2cb226757a8bf90dac33bd04f87f325654220/build-end.log
>
> For some odd reason, I don't see the davincifb.h file in the directfb
> tarball, but it IS in git:
>
> http://git.directfb.org/?p=core/DirectFB.git;a=tree;f=gfxdrivers/davinci;h=f0bd9ad6add6164f3a5e953d4eed4056315a2be2;hb=ab0d779e85cec22c7c2e7b8b6b1976049b1ba0f1
>
> Is it working for you? If so, how?

  davincifb.h is the kernel header file which contains the davinci-specific
interfaces.  Unfortunately the davinci stuff doesn't get upstreamed, so you
need a davinci-specific fork like
git://arago-project.org/git/projects/linux-davinci.git

  I thought I tested it with davinci-specific kernel headers, but I can't
find the output anymore and I can't reproduce it...

  One solution would be to add includethe davincifb.h file with a buildroot
patch. However, I don't have a davinci board anymore so I can't even test
if it works.

  Therefore, I prefer to revert the patch.

  Regards,
  Arnout
Peter Korsgaard - May 6, 2012, 11:40 a.m.
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> For some odd reason, I don't see the davincifb.h file in the directfb
 >> tarball, but it IS in git:
 >> 
 >> http://git.directfb.org/?p=core/DirectFB.git;a=tree;f=gfxdrivers/davinci;h=f0bd9ad6add6164f3a5e953d4eed4056315a2be2;hb=ab0d779e85cec22c7c2e7b8b6b1976049b1ba0f1
 >> 
 >> Is it working for you? If so, how?

 Arnout>  davincifb.h is the kernel header file which contains the
 Arnout> davinci-specific interfaces.  Unfortunately the davinci stuff
 Arnout> doesn't get upstreamed, so you need a davinci-specific fork
 Arnout> like git://arago-project.org/git/projects/linux-davinci.git

 Arnout>  I thought I tested it with davinci-specific kernel headers,
 Arnout> but I can't find the output anymore and I can't reproduce it...

 Arnout>  One solution would be to add includethe davincifb.h file with
 Arnout> a buildroot patch. However, I don't have a davinci board
 Arnout> anymore so I can't even test if it works.

 Arnout>  Therefore, I prefer to revert the patch.

Ok, if nobody else thinks otherwise then I'll revert.
Peter Korsgaard - May 15, 2012, 7:58 p.m.
>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:

Hi,

 Arnout> Therefore, I prefer to revert the patch.

 Peter> Ok, if nobody else thinks otherwise then I'll revert.

Reverted.

Patch

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 47f9fea..26f5091 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -53,6 +53,10 @@  config BR2_PACKAGE_DIRECTFB_EP9X
 	bool "compile ep9x graphics driver"
 	depends on BR2_arm
 
+config BR2_PACKAGE_DIRECTFB_DAVINCI
+	bool "compile TI DaVinci graphics driver"
+	depends on BR2_arm
+
 config BR2_PACKAGE_DIRECTFB_UNICHROME
 	bool "compile unichrome graphics driver"
 	default y
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 071cdf4..7aa0398 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -58,7 +58,8 @@  DIRECTFB_GFX := \
 	$(if $(BR2_PACKAGE_DIRECTFB_PXA3XX),pxa3xx) \
 	$(if $(BR2_PACKAGE_DIRECTFB_UNICHROME),unichrome) \
 	$(if $(BR2_PACKAGE_DIRECTFB_I830),i830)	\
-	$(if $(BR2_PACKAGE_DIRECTFB_EP9X),ep9x)
+	$(if $(BR2_PACKAGE_DIRECTFB_EP9X),ep9x) \
+	$(if $(BR2_PACKAGE_DIRECTFB_DAVINCI),davinci)
 
 ifeq ($(strip $(DIRECTFB_GFX)),)
 DIRECTFB_GFX:=none