diff mbox

qdev: Fix memory leak in function set_pci_devfn

Message ID 1335616362-14778-1-git-send-email-sw@weilnetz.de
State Accepted
Headers show

Commit Message

Stefan Weil April 28, 2012, 12:32 p.m. UTC 
Valgrind reported this memory leak which occured very often.

Test scenario:

qemu-system-i386 (no arguments), only BIOS started, terminate with
monitor command (quit).

v2:
Use error_free instead of g_free (hint from Andreas Färber, thanks).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/qdev-properties.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Andreas Färber April 28, 2012, 12:53 p.m. UTC | #1 
Am 28.04.2012 14:32, schrieb Stefan Weil:
> Valgrind reported this memory leak which occured very often.
> 
> Test scenario:
> 
> qemu-system-i386 (no arguments), only BIOS started, terminate with
> monitor command (quit).
> 
> v2:
> Use error_free instead of g_free (hint from Andreas Färber, thanks).
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Acked-by: Andreas Färber <afaerber@suse.de>

/-F
diff mbox

Patch

diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 98dd06a..c5545dc 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -834,6 +834,7 @@  static void set_pci_devfn(Object *obj, Visitor *v, void *opaque,
 
     visit_type_str(v, &str, name, &local_err);
     if (local_err) {
+        error_free(local_err);
         return set_int32(obj, v, opaque, name, errp);
     }