From patchwork Sat Apr 28 01:29:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 155612 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5B30FB6FD0 for ; Sat, 28 Apr 2012 11:34:16 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SNwWo-00037N-P2; Sat, 28 Apr 2012 01:32:50 +0000 Received: from mail-pz0-f43.google.com ([209.85.210.43]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SNwWl-00036o-Kq for linux-mtd@lists.infradead.org; Sat, 28 Apr 2012 01:32:48 +0000 Received: by dadn15 with SMTP id n15so2142415dad.16 for ; Fri, 27 Apr 2012 18:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=zEHlT5a0xkYLnoMC/5rrEzYlq16VqtzO3Z9EB5vnJ8I=; b=cWl5QzzmgRnMD3asJbJhlMlknG32RQKhkt66ET74kHaWdW+4QjzZqDv/+URCC/bESi h0s8YH4zOgtg5SRxdXTgeFgCQ5ZlFHa9s/Tl+8YXMRi7KYUFXrHeTla7YiitzNOrGVFc OvR3Mx09NhFyrAcLKjgnrIu+nVvw99tELRIWgxjnq6OTwwBXAysZkKfcXNF5oyeYDX+n RRf5QlvYrCDpKlCjDD7haeAj3iaX3txf3iK3mAtvqujVSeMjXhHw41cuJN4TC1RU32Pt avLQWsbbfuqWvHelMTvB4dxqQtyu6v3n1y/WaYZx9P1tzz5nRrQY87q5652jN7IRluhd ogCg== Received: by 10.68.230.226 with SMTP id tb2mr2185427pbc.57.1335576766845; Fri, 27 Apr 2012 18:32:46 -0700 (PDT) Received: from localhost.localdomain (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPS id 2sm8068633pbw.57.2012.04.27.18.32.45 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Apr 2012 18:32:46 -0700 (PDT) From: Brian Norris To: Subject: [PATCH v3 04/10] mtd: cafe_nand: utilize oob_required parameter Date: Fri, 27 Apr 2012 18:29:48 -0700 Message-Id: <1335576594-25267-5-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 1.7.5.4.2.g519b1 In-Reply-To: <1335576594-25267-1-git-send-email-computersforpeace@gmail.com> References: <1335576594-25267-1-git-send-email-computersforpeace@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.43 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Brian Norris , David Woodhouse , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Don't write OOB if the caller doesn't require it. Signed-off-by: Brian Norris --- drivers/mtd/nand/cafe_nand.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/cafe_nand.c b/drivers/mtd/nand/cafe_nand.c index 738aafa..4c9714b 100644 --- a/drivers/mtd/nand/cafe_nand.c +++ b/drivers/mtd/nand/cafe_nand.c @@ -525,7 +525,8 @@ static void cafe_nand_write_page_lowlevel(struct mtd_info *mtd, struct cafe_priv *cafe = mtd->priv; chip->write_buf(mtd, buf, mtd->writesize); - chip->write_buf(mtd, chip->oob_poi, mtd->oobsize); + if (oob_required) + chip->write_buf(mtd, chip->oob_poi, mtd->oobsize); /* Set up ECC autogeneration */ cafe->ctl2 |= (1<<30);