From patchwork Fri Apr 27 16:58:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 155550 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5510AB6FBA for ; Sat, 28 Apr 2012 02:58:59 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1336150740; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=6Z9ARnlnhV8JWMCaZIbQsJqOzQY=; b=dFUqnb0e35AP+zR XXlw6gFTi66cqjEkHJaSjlemdKHxAKM3dvkBV2408hve2dyy885I/PZqO/NrJ5Uy DeHSKwy0OupaCii8ITAqobz7M0EYmvltk6S0fKzSbq/nwanFBnwiXBg0RXFW5pbr XJcR/Imi3zt5+NWPnKZOchXs7QDY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=mPuBZA7iBmUQqkCI7oAKlNrcoAl8JcS1z8EXKjO+F4jK8m6w9RXRnrQ6qEpeB6 IkraAzX4Ss3Mi+qFtgYPn0q9wuSipArN6S6wHIa8QODKnRNGT4msCkpT5GG2EuTA t1g13Zua0QnHvcf5LT0ruG1MNbjSpUe8sY9tD/AXZWhfc=; Received: (qmail 18652 invoked by alias); 27 Apr 2012 16:58:54 -0000 Received: (qmail 18641 invoked by uid 22791); 27 Apr 2012 16:58:52 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 16:58:33 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3RGwX6R013832 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Apr 2012 12:58:33 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3RGwVBX010465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 27 Apr 2012 12:58:32 -0400 From: Tom Tromey To: "H.J. Lu" Cc: Jakub Jelinek , DJ Delorie , dje@google.com, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: RFA: consolidate DWARF strings into libiberty References: <871uotbscq.fsf@fleche.redhat.com> <201203191613.q2JGCx5m011858__41727.2307830446$1332173667$gmane$org@greed.delorie.com> <87obrsmrma.fsf__45145.0892644518$1332177916$gmane$org@fleche.redhat.com> <87fwcqndx8.fsf@fleche.redhat.com> <87limadll4.fsf@fleche.redhat.com> <87d37bwgq1.fsf__11149.6676145636$1334346880$gmane$org@fleche.redhat.com> <87ipgqfqwx.fsf@fleche.redhat.com> <20120426144248.GA16117@tyan-ft48-01.lab.bos.redhat.com> <201204261752.q3QHqVgh017388@greed.delorie.com> <20120426203911.GC16117__46696.8788685792$1335472814$gmane$org@tyan-ft48-01.lab.bos.redhat.com> <87wr515kp6.fsf@fleche.redhat.com> <87ipgl40nz.fsf@fleche.redhat.com> Date: Fri, 27 Apr 2012 10:58:31 -0600 In-Reply-To: <87ipgl40nz.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 27 Apr 2012 10:09:04 -0600") Message-ID: <874ns53ydk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org >>>>> "Tom" == Tom Tromey writes: HJ> You should add extern "C" for C++ on those functions moved to HJ> libiberty. Tom> Yeah, sorry about that. Tom> I'm testing the fix. Here is what I am checking in. Tom ChangeLog: 2012-04-27 Tom Tromey * dwarf2.h: Wrap function declarations in extern "C". Index: dwarf2.h =================================================================== --- dwarf2.h (revision 186908) +++ dwarf2.h (working copy) @@ -361,6 +361,10 @@ #define DW_EH_PE_indirect 0x80 +#ifdef __cplusplus +extern "C" { +#endif /* __cplusplus */ + /* Return the name of a DW_TAG_ constant, or NULL if the value is not recognized. */ extern const char *get_DW_TAG_name (unsigned int tag); @@ -385,4 +389,8 @@ recognized. */ extern const char *get_DW_CFA_name (unsigned int opc); +#ifdef __cplusplus +} +#endif /* __cplusplus */ + #endif /* _DWARF2_H */