Patchwork [U-Boot,v2,2/4] patman: Add meaningful statements instead of blah blah

login
register
mail settings
Submitter Vikram Narayanan
Date April 27, 2012, 4:39 p.m.
Message ID <4F9ACBB8.2040408@gmail.com>
Download mbox | patch
Permalink /patch/155544/
State Rejected
Delegated to: Tom Rini
Headers show

Comments

Vikram Narayanan - April 27, 2012, 4:39 p.m.
Add example statements for commit message and series messages

Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
---
 tools/patman/README |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
Wolfgang Denk - April 30, 2012, 7:44 a.m.
Dear Vikram Narayanan,

In message <4F9ACBB8.2040408@gmail.com> you wrote:
> Add example statements for commit message and series messages
> 
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  tools/patman/README |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/patman/README b/tools/patman/README
> index d9820ab..d98f081 100644
> --- a/tools/patman/README
> +++ b/tools/patman/README
> @@ -132,16 +132,15 @@ Series-prefix: prefix
>  
>  Cover-letter:
>  This is the patch set title
> -blah blah
> -more blah blah
> +This patch set fixes the errors when CONFIG_xxx is enabled.
> +Tested on xyz board.
>  END
>  	Sets the cover letter contents for the series. The first line
>  	will become the subject of the cover letter
>  
>  Series-notes:
> -blah blah
> -blah blah
> -more blah blah
> +Sorry that I couldn't find time to reply for the comments posted on the v1 of my
> +patch. This patch supersedes v1. Please comment.
>  END
>  	Sets some notes for the patch series, which you don't want in
>  	the commit messages, but do want to send, The notes are joined

I'm not sure this is an improvement. Your example messages are pretty
much specific, so people in completely different situations will not
find much help in them either.

I suggest we leave the text as is.  What do you think?

Best regards,

Wolfgang Denk
Vikram Narayanan - April 30, 2012, 1:35 p.m.
Hello Wolfgang,

On 4/30/2012 1:14 PM, Wolfgang Denk wrote:
> Dear Vikram Narayanan,
>
> In message<4F9ACBB8.2040408@gmail.com>  you wrote:
>> Add example statements for commit message and series messages
>>
>> Signed-off-by: Vikram Narayanan<vikram186@gmail.com>
>> Cc: Simon Glass<sjg@chromium.org>
>> ---
>>   tools/patman/README |    9 ++++-----
>>   1 files changed, 4 insertions(+), 5 deletions(-)
>>
<snip>
> I'm not sure this is an improvement. Your example messages are pretty
> much specific, so people in completely different situations will not
> find much help in them either.
>
> I suggest we leave the text as is.  What do you think?

Yes. Then, its better to leave as it is.

Regards,
Vikram

Patch

diff --git a/tools/patman/README b/tools/patman/README
index d9820ab..d98f081 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -132,16 +132,15 @@  Series-prefix: prefix
 
 Cover-letter:
 This is the patch set title
-blah blah
-more blah blah
+This patch set fixes the errors when CONFIG_xxx is enabled.
+Tested on xyz board.
 END
 	Sets the cover letter contents for the series. The first line
 	will become the subject of the cover letter
 
 Series-notes:
-blah blah
-blah blah
-more blah blah
+Sorry that I couldn't find time to reply for the comments posted on the v1 of my
+patch. This patch supersedes v1. Please comment.
 END
 	Sets some notes for the patch series, which you don't want in
 	the commit messages, but do want to send, The notes are joined