Patchwork [v2,1/2] Update copyright banners

login
register
mail settings
Submitter Andreas Färber
Date April 27, 2012, 10:08 a.m.
Message ID <1335521295-26117-2-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/155455/
State New
Headers show

Comments

Andreas Färber - April 27, 2012, 10:08 a.m.
The copyright statements printed by the various executables have not
been touched since r3893 / 68d0f70e3c180253b637996f985dd9d248bd910a.
So, judging by -version output, a user could get the impression that
QEMU was last modified in 2008. We should therefore update it to the
current year.

However just changing the year seems wrong since Fabrice didn't
contribute in recent years. Therefore extend the copyright statement to
cover "Fabrice Bellard and contributors" so that it can be updated
to the current year.

Cc: Fabrice Bellard <fabrice@bellard.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 bsd-user/main.c   |    3 ++-
 linux-user/main.c |    2 +-
 vl.c              |    3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
Daniel P. Berrange - April 27, 2012, 10:49 a.m.
On Fri, Apr 27, 2012 at 12:08:14PM +0200, Andreas Färber wrote:
> The copyright statements printed by the various executables have not
> been touched since r3893 / 68d0f70e3c180253b637996f985dd9d248bd910a.
> So, judging by -version output, a user could get the impression that
> QEMU was last modified in 2008. We should therefore update it to the
> current year.
> 
> However just changing the year seems wrong since Fabrice didn't
> contribute in recent years. Therefore extend the copyright statement to
> cover "Fabrice Bellard and contributors" so that it can be updated
> to the current year.

[snip]

> diff --git a/vl.c b/vl.c
> index ae91a8a..9798f87 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1561,7 +1561,8 @@ static void main_loop(void)
>  
>  static void version(void)
>  {
> -    printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
> +    printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION
> +           ", Copyright (c) 2003-2012 Fabrice Bellard and contributors\n");
>  }

libvirt doesn't loook at anything after the version numbers, so changing
the copyright part should be just fine from our POV.

Regards,
Daniel

Patch

diff --git a/bsd-user/main.c b/bsd-user/main.c
index 0689e38..b2b5b69 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -672,7 +672,8 @@  void cpu_loop(CPUSPARCState *env)
 
 static void usage(void)
 {
-    printf("qemu-" TARGET_ARCH " version " QEMU_VERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"
+    printf("qemu-" TARGET_ARCH " version " QEMU_VERSION
+           ", Copyright (c) 2003-2012 Fabrice Bellard and contributors\n"
            "usage: qemu-" TARGET_ARCH " [options] program [arguments...]\n"
            "BSD CPU emulator (compiled for %s emulation)\n"
            "\n"
diff --git a/linux-user/main.c b/linux-user/main.c
index 191b750..8762075 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -3120,7 +3120,7 @@  static void handle_arg_strace(const char *arg)
 static void handle_arg_version(const char *arg)
 {
     printf("qemu-" TARGET_ARCH " version " QEMU_VERSION QEMU_PKGVERSION
-           ", Copyright (c) 2003-2008 Fabrice Bellard\n");
+           ", Copyright (c) 2003-2012 Fabrice Bellard and contributors\n");
     exit(0);
 }
 
diff --git a/vl.c b/vl.c
index ae91a8a..9798f87 100644
--- a/vl.c
+++ b/vl.c
@@ -1561,7 +1561,8 @@  static void main_loop(void)
 
 static void version(void)
 {
-    printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
+    printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION
+           ", Copyright (c) 2003-2012 Fabrice Bellard and contributors\n");
 }
 
 static void help(int exitcode)