From patchwork Fri Apr 27 09:18:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 155401 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9008FB6EF3 for ; Fri, 27 Apr 2012 19:19:06 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1336123146; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:Date:Message-ID:Subject:From:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=i+u2AGO bneUN3wGlrY7IBtkPNuo=; b=bfjbrrkiZOW9JfN0Jm6PlxEGOZIqhYe7VdXkl1x UN/9Jx4A0Npc0Tr5qJYK+wOgzQUgX6C396iVQ0VDpZij6wvWsctlfRXgwxcvYipf MlhbIjStdVb4TbwOir5+bZRvRud11Scomsv4bla97G1edyVkwEquL7Xe/YhA2StC TjYg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=FOCGTBmJVi23ZohnxR0x62vZQYL8FSi3IA5Oe3EQ4UW2NeZkExlOjH1X2ud2Z4 luTREjq2tuLAMFnQ9241+P7jq7MzIx6UWGGlUv72Mp0mUl/nenw7sSo4YGsQdTN0 vfol1XblPW8zQshK6yAOxo21xybTSMqCMNlxYgOX2IZkc=; Received: (qmail 26866 invoked by alias); 27 Apr 2012 09:19:02 -0000 Received: (qmail 26858 invoked by uid 22791); 27 Apr 2012 09:19:02 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-yx0-f175.google.com (HELO mail-yx0-f175.google.com) (209.85.213.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 09:18:49 +0000 Received: by yenm3 with SMTP id m3so244187yen.20 for ; Fri, 27 Apr 2012 02:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.75.232 with SMTP id z68mr10748878yhd.6.1335518329153; Fri, 27 Apr 2012 02:18:49 -0700 (PDT) Received: by 10.100.90.6 with HTTP; Fri, 27 Apr 2012 02:18:49 -0700 (PDT) Date: Fri, 27 Apr 2012 11:18:49 +0200 Message-ID: Subject: [patch] Obvious: Fix DF solution dirty marking in cfg.c:disconnect_src From: Steven Bosscher To: GCC Patches , Paolo Bonzini X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, It makes no sense to mark DF solutions dirty on the gcc_unreachable() path but not on the return path. Bootstrapped&tested on x86_64-unknown-linux-gnu and powerpc64-unknown-linux-gnu. I'll this, as obvious, some time late next week unless I hear objections. Ciao! Steven * cfg.c (disconnect_src): Do df_mark_solutions_dirty in the right place. Index: cfg.c =================================================================== --- cfg.c (revision 186897) +++ cfg.c (working copy) @@ -242,13 +242,13 @@ disconnect_src (edge e) if (tmp == e) { VEC_unordered_remove (edge, src->succs, ei.index); + df_mark_solutions_dirty (); return; } else ei_next (&ei); } - df_mark_solutions_dirty (); gcc_unreachable (); }